From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling
Date: Tue, 9 Jul 2013 13:01:15 -0400 [thread overview]
Message-ID: <20130709170115.GA4846@bill-the-cat> (raw)
In-Reply-To: <20130708142213.GO16630@bill-the-cat>
On Mon, Jul 08, 2013 at 10:22:13AM -0400, Tom Rini wrote:
> On Mon, Jul 08, 2013 at 09:17:10AM -0500, Robert Nelson wrote:
>
> > On Mon, Jul 8, 2013 at 9:13 AM, Tom Rini <trini@ti.com> wrote:
> > > On Thu, Jul 04, 2013 at 01:26:11PM -0700, Simon Glass wrote:
> > >> In the recent bootm refactor, the PREP stage was missing in the bootz
> > >> command. This causes unpredictable behaviour.
> > >>
> > >> The use of a local variable means that the reset of cmd_bootm.c does not
> > >> in fact use the same image structure, so remove this.
> > >>
> > >> Also manually set the OS type to Linux, since this is the only possibility
> > >> at present, and we need to select the right boot function.
> > >>
> > >> Signed-off-by: Simon Glass <sjg@chromium.org>
> > >
> > > With the whole series applied, I still see a hang at:
> > > Kernel image @ 0x80200000 [ 0x000000 - 0x3d44a0 ]
> > >
> > > Starting kernel ...
> > >
> > > Perhaps something to do with how my DDR is not at 0x0 -> 256MiB but
> > > 0x80000000 -> 256MiB ?
> >
> >
> > Tom, which board is that?
> >
> > These 5 patches just on top of v2013.07-rc2, the panda (non es) (board
> > file) works, but Wand (device tree) is still locking up for me...
> >
> > Panda (Board file boot)
> >
> > load mmc ${mmcdev}:${mmcpart} ${loadaddr} zImage
> > run mmcargs
> > bootz ${loadaddr}
>
> Ah-ha! It's an appended dtb vs not problem now. I can boot my
> beagelbone with with an appended dtb and bootz, but can't with separate.
OK, the BOOTM_STATE_FINDOTHER state code isn't working since we don't
have the rest of the header bits that the code checks for set. I've
taken a few stabs at reworking things, but it's not working yet. Simon,
do you have any ideas here? I'm starting to wonder if we don't need to
revert things afterall and sort this out post release.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130709/875d501e/attachment.pgp>
next prev parent reply other threads:[~2013-07-09 17:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 20:26 [U-Boot] [PATCH v2 2/5] bootm: Disable interrupts only when loading Simon Glass
2013-07-04 20:26 ` [U-Boot] [PATCH v2 3/5] bootm: Require boot function only if it is about to be used Simon Glass
2013-07-04 20:26 ` [U-Boot] [PATCH v2 4/5] bootm: Clean up bootz_setup() function Simon Glass
2013-07-04 20:26 ` [U-Boot] [PATCH v2 5/5] bootm: Add the missing PREP stage to bootz and correct image handling Simon Glass
2013-07-08 14:13 ` Tom Rini
2013-07-08 14:17 ` Robert Nelson
2013-07-08 14:22 ` Tom Rini
2013-07-09 17:01 ` Tom Rini [this message]
2013-07-09 19:00 ` Simon Glass
2013-07-09 19:05 ` Tom Rini
2013-07-09 20:04 ` Simon Glass
2013-07-09 21:19 ` Tom Rini
2013-07-09 21:24 ` Robert Nelson
2013-07-09 21:39 ` Robert Nelson
2013-07-09 21:44 ` Simon Glass
2013-07-10 9:51 ` Sughosh Ganu
2013-07-10 10:08 ` Simon Glass
2013-07-11 6:03 ` Sughosh Ganu
2013-07-11 6:56 ` Simon Glass
2013-07-12 8:21 ` Sughosh Ganu
2013-07-12 16:49 ` Simon Glass
2013-07-10 10:13 ` Simon Glass
2013-07-10 10:15 ` Simon Glass
2013-07-09 19:05 ` Robert Nelson
2013-07-10 13:18 ` [U-Boot] [PATCH v2 2/5] bootm: Disable interrupts only when loading Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130709170115.GA4846@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox