public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] image: Don't relocate ramdisk to highmem
Date: Thu, 11 Jul 2013 11:46:19 +0200	[thread overview]
Message-ID: <20130711094619.E6D2B383003@gemini.denx.de> (raw)
In-Reply-To: <1373500071-6476-1-git-send-email-thierry.reding@gmail.com>

Dear Thierry Reding,

In message <1373500071-6476-1-git-send-email-thierry.reding@gmail.com> you wrote:
> 
> The Linux kernel cannot unpack a ramdisk that's stored in high memory.

Can you please be a bit more explicit?  Which exact architecture are
you talking about?  Can you show a specific example of an error case
for such a system?

> -		/* not set, no restrictions to load high */
> -		initrd_high = ~0;
> +		/* make sure to put ramdisk in low memory */
> +		initrd_high = getenv_bootm_low() + getenv_bootm_mapsize();

I don't like to have such a patch (which affects ALL systems) added
unless we understand exactly why we should do that. 

Why do you not simply set initrd_high as needed?

Also, when changing the behaviour, you should also update the
comments.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The trouble with our times is that the future is not what it used  to
be.                                                     - Paul Valery

  reply	other threads:[~2013-07-11  9:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10 23:47 [U-Boot] [PATCH] image: Don't relocate ramdisk to highmem Thierry Reding
2013-07-11  9:46 ` Wolfgang Denk [this message]
2013-07-11 12:39   ` Tom Rini
2013-07-11 15:00     ` Thierry Reding
2013-07-11 18:21       ` Wolfgang Denk
2013-07-11 18:29         ` Tom Rini
2013-07-11 19:06         ` Stephen Warren
2013-07-11 20:55           ` Wolfgang Denk
2013-07-11 19:08         ` Thierry Reding
2013-07-11 20:57           ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130711094619.E6D2B383003@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox