From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Date: Thu, 11 Jul 2013 23:35:06 -0500 Subject: [U-Boot] [PATCH 1/5] omap3_beagle: remove JFFS2 support. In-Reply-To: References: <1373579559-5697-1-git-send-email-nm@ti.com> <1373579559-5697-2-git-send-email-nm@ti.com> <51DF6EB0.6020108@ti.com> <20130712034922.GA20823@kahuna> Message-ID: <20130712043506.GA20986@kahuna> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 23:25-20130711, Joel Fernandes wrote: > On Thu, Jul 11, 2013 at 10:49 PM, Nishanth Menon wrote: > > On 21:49-20130711, Joel Fernandes wrote: > >> On Thu, Jul 11, 2013 at 4:52 PM, Nishanth Menon wrote: > >> > We do not use JFFS2 by default and it conflicts with > >> > CONFIG_CMD_FS_GENERIC (ls command is the same). Since most of our > >> > BOOTCMD can be simplified by using the FS_GENERIC, dropping JFFS2 > >> > > >> > Signed-off-by: Nishanth Menon > >> > --- > >> > include/configs/omap3_beagle.h | 8 -------- > >> > 1 file changed, 8 deletions(-) > >> > > >> > diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h > >> > index 48ce4c0..9adf4a5 100644 > >> > --- a/include/configs/omap3_beagle.h > >> > +++ b/include/configs/omap3_beagle.h > >> > @@ -150,7 +150,6 @@ > >> > #define CONFIG_CMD_CACHE > >> > #define CONFIG_CMD_EXT2 /* EXT2 Support */ > >> > #define CONFIG_CMD_FAT /* FAT support */ > >> > -#define CONFIG_CMD_JFFS2 /* JFFS2 Support */ > >> > #define CONFIG_CMD_MTDPARTS /* Enable MTD parts commands */ > >> > #define CONFIG_MTD_DEVICE /* needed for mtdparts commands */ > >> > #define MTDIDS_DEFAULT "nand0=nand" > >> > @@ -203,13 +202,6 @@ > >> > > >> > #define CONFIG_SYS_MAX_NAND_DEVICE 1 /* Max number of NAND */ > >> > /* devices */ > >> > -#define CONFIG_JFFS2_NAND > >> > -/* nand device jffs2 lives on */ > >> > -#define CONFIG_JFFS2_DEV "nand0" > >> > -/* start of jffs2 partition */ > >> > -#define CONFIG_JFFS2_PART_OFFSET 0x680000 > >> > -#define CONFIG_JFFS2_PART_SIZE 0xf980000 /* size of jffs2 */ > >> > > >> > >> Minor nit, can we perhaps leave the JFFS configuration and only remove/comment > >> CONFIG_CMD_JFFS. That way we wont lose these paritition offsets/size for folks > >> who might need them. > > then we have to drop the usage of FS_GENERIC. code wont build with both. > > No I meant drop CMD_JFFS but not the other JFFS. Those wont come into play unless CMD_JFFS2 is enabled, and as stated, makes no sense to keep the second part around and trick some poor bloke into thinking CMD_JFFS2 was left out by mistake.. > > > There is no point in keeping something as an option if it cant be used. > > dont you agree? > > Either way is OK with me, you have a point too. OK, will take this to mean that you are ok with the patch as is. Thanks for the review. -- Regards, Nishanth Menon