From: Sughosh Ganu <urwithsughosh@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] blackfin: x86: bootm: Handle PREP stage of bootm
Date: Fri, 12 Jul 2013 13:58:05 +0530 [thread overview]
Message-ID: <20130712082805.GB3047@Hardy> (raw)
In-Reply-To: <1373522891-7677-3-git-send-email-sjg@chromium.org>
On Wed Jul 10, 2013 at 11:08:09PM -0700, Simon Glass wrote:
> The OS function is now always called with the PREP stage. Adjust the
> remaining bootm OS functions to deal with this correctly.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> arch/blackfin/lib/boot.c | 2 ++
> arch/x86/lib/bootm.c | 2 ++
> common/cmd_bootm.c | 16 ++++++++++++++++
> 3 files changed, 20 insertions(+)
>
> diff --git a/arch/blackfin/lib/boot.c b/arch/blackfin/lib/boot.c
> index 768a882..5644d58 100644
> --- a/arch/blackfin/lib/boot.c
> +++ b/arch/blackfin/lib/boot.c
> @@ -42,6 +42,8 @@ int do_bootm_linux(int flag, int argc, char * const argv[], bootm_headers_t *ima
> int (*appl) (char *cmdline);
> char *cmdline;
>
> + if (flag & BOOTM_STATE_OS_PREP)
> + return 0;
> if ((flag != 0) && (flag != BOOTM_STATE_OS_GO))
> return 1;
Minor nit; A blank line between the two if conditions would be
good. Applies for all the hunks in this patch.
-sughosh
next prev parent reply other threads:[~2013-07-12 8:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 6:08 [U-Boot] [PATCH 0/4] Correct some remaining bootm problems Simon Glass
2013-07-11 6:08 ` [U-Boot] [PATCH 1/4] bootm: Remove extra OK message Simon Glass
2013-07-11 6:08 ` [U-Boot] [PATCH 2/4] blackfin: x86: bootm: Handle PREP stage of bootm Simon Glass
2013-07-12 8:28 ` Sughosh Ganu [this message]
2013-07-11 6:08 ` [U-Boot] [PATCH 3/4] bootm: Use selected configuration for ramdisk and fdt Simon Glass
2013-07-11 6:08 ` [U-Boot] [PATCH 4/4] bootm: Correct the arguments for the ELF image loader Simon Glass
2013-07-12 21:23 ` [U-Boot] [PATCH 0/4] Correct some remaining bootm problems Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130712082805.GB3047@Hardy \
--to=urwithsughosh@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox