From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 12 Jul 2013 13:48:03 +0200 Subject: [U-Boot] [PATCH] mx28evk: Convert to phylib framework In-Reply-To: References: <1373603284-884-1-git-send-email-festevam@gmail.com> <201307120658.41345.marex@denx.de> Message-ID: <201307121348.03722.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Alexandre Pereira da Silva, > On Fri, Jul 12, 2013 at 1:58 AM, Marek Vasut wrote: > > Dear Fabio Estevam, > > > >> On Fri, Jul 12, 2013 at 1:40 AM, Marek Vasut wrote: > >> > Dear Fabio Estevam, > >> > > >> >> From: Fabio Estevam > >> >> > >> >> mx28evk has a LAN8270 ethernet phy and we can use the phylib > >> >> framework. > >> >> > >> >> One of the advantages of converting to phylib is that we no longer > >> >> see a timeout prior to the first transfer in the 'tftp' command. > >> >> > >> >> Signed-off-by: Fabio Estevam > >> >> --- > >> >> After applying this patch I get: > >> >> > >> >> U-Boot 2013.04-11810-gd6d75ec-dirty (Jul 12 2013 - 01:15:03) > >> >> > >> >> CPU: Freescale i.MX28 rev1.2 at 454 MHz > >> >> BOOT: SSP SD/MMC #0, 3V3 > >> >> DRAM: 128 MiB > >> >> MMC: MXS MMC: 0 > >> >> Video: MXSFB: 'videomode' variable not set! > >> >> In: serial > >> >> Out: serial > >> >> Err: serial > >> >> Net: Phy not found > >> >> > >> >> I still get this 'Phy not found' message, but I think this is not > >> >> related to the board code. > >> > > >> > This is because PHYlib doesn't know your PHY. You might need to add a > >> > definition for it into drivers/net/phy/smsc.c > >> > >> mx28evk uses a LAN8270. > >> > >> drivers/net/phy/smsc.c has an entry for "SMSC LAN8710/LAN8720", so not > >> sure why it fails to recognize it. > >> I haven't debugged it yet. > >> > >> Which phy does sc_sps_1.h use? Is it also a 8720? Is the phy recognized > >> on boot? > > > > I think it's 8720 , but it's recognised , yes. Are you sure the PHY > > addresses are correct ? You can dig into phylib a bit and see what IDs > > does it report. > > I think Fabio needs to define CONFIG_PHY_SMSC and use PHY address 3. He already did and the LAN8720 can use either phy addr 0x00 or 0x01, so that seem ok as well. Best regards, Marek Vasut