[U-Boot] [PATCH] tools: fix FIT image with ramdisk

[Albert ARIBAUD <albert.u.boot@aribaud.net>]

Hi Stefano,

On Fri, 12 Jul 2013 15:09:23 +0200, Stefano Babic <sbabic@denx.de>
wrote:

> Booting a FIT image containing a ramdisk,
> the ramdisk is loaded at address 0x0 that causes
> bus errors for architectures that do not have
> RAM starting at address zero.

Kind-of-minor nitpick: ARMs which have RAM at address 0 might well have
their exception tables there too (and will if they don't right now),
which makes it always bad to to load anything there anyway.

Properly major nitpick: the commit message explains what needed fixing,
but neither the commit message nor the code (to an admittedly completely
unFIT reader) explain *how* exactly it was fixed.

> Signed-off-by: Stefano Babic <sbabic@denx.de>
> 
> ---
>  common/image.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/image.c b/common/image.c
> index 1be384f..08f712a 100644
> --- a/common/image.c
> +++ b/common/image.c
> @@ -910,7 +910,7 @@ int boot_get_ramdisk(int argc, char * const argv[], bootm_headers_t *images,
>  					fit_uname_config, arch,
>  					IH_TYPE_RAMDISK,
>  					BOOTSTAGE_ID_FIT_RD_START,
> -					FIT_LOAD_REQUIRED, &rd_data, &rd_len);
> +					FIT_LOAD_IGNORED, &rd_data, &rd_len);
>  			if (rd_noffset < 0)
>  				return 1;
>  


Amicalement,
-- 
Albert.