From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc: mpc8323erdb: Fix compiler warning
Date: Mon, 15 Jul 2013 01:32:50 +0200 [thread overview]
Message-ID: <201307150132.50811.marex@denx.de> (raw)
In-Reply-To: <20130714174348.B7BF7380DFF@gemini.denx.de>
Hello Wolfgang,
> Dear Marek Vasut,
>
> In message <1373710940-15779-1-git-send-email-marex@denx.de> you wrote:
> > Fix the following warning:
> >
> > mpc8323erdb.c: In function 'mac_read_from_eeprom':
> > mpc8323erdb.c:198:3: warning: dereferencing type-punned pointer will
> > break strict-aliasing rules [-Wstrict-aliasing]
> >
> > if (crc32(crc, buf, 24) == *(unsigned int *)&buf[24]) {
> > ^
> >
> > Size remains unchanged after and before fix:
> > text data bss dec hex filename
> >
> > 206977 18748 23344 249069 3cced ./u-boot
> >
> > Note the fix is the crudest possible, but also least intrusive.
>
> Please see Timur's review comments to my original patch for this
> isssue ([1]). The "unsigned int" should indeed be fixed.
>
> I resubmitted a v2 with the review comments incorporated on July 08,
> see [2], but I caught only one part of the needed changes. V3 sent
> right now; see [3]. I'd rather see this added than yours.
OK, I didn't know you were at it.
> Also note that it might be a good idea to add the MPC83xx custodion to
> the Cc: list of such patches...
Yes, I only added the board maintainer, who's apparently no longer at FSL :(
> [1] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/163386
> [2] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/165266
> [3] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/165731
Best regards,
Marek Vasut
prev parent reply other threads:[~2013-07-14 23:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-13 10:22 [U-Boot] [PATCH] ppc: mpc8323erdb: Fix compiler warning Marek Vasut
2013-07-14 17:43 ` Wolfgang Denk
2013-07-14 23:32 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201307150132.50811.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox