From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Date: Mon, 15 Jul 2013 07:25:02 -0500 Subject: [U-Boot] [PATCH V3 5/6] omap3_beagle: support findfdt and loadfdt for devicetree support In-Reply-To: References: <20130712151034.GN13531@bill-the-cat> <1373890293-23303-1-git-send-email-nm@ti.com> <1373890293-23303-6-git-send-email-nm@ti.com> Message-ID: <20130715122502.GA23448@kahuna> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 14:16-20130715, Koen Kooi wrote: > > Op 15 jul. 2013, om 14:11 heeft Nishanth Menon het volgende geschreven: > > > For folks not using concatenated device tree with uImage, having > > an handy function to find and load device tree is very handy. > > > > So introduce findfdt and loadfdt and run findfdt by default to make > > it easier on user scripts. > > > > Signed-off-by: Nishanth Menon > > --- > > V3: Fixes typo mistake reported in http://marc.info/?t=137358212300006&r=1&w=2 > > > > include/configs/omap3_beagle.h | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h > > index bdeee17..5ec8ade 100644 > > --- a/include/configs/omap3_beagle.h > > +++ b/include/configs/omap3_beagle.h > > @@ -210,6 +210,8 @@ > > #define CONFIG_EXTRA_ENV_SETTINGS \ > > "loadaddr=0x80200000\0" \ > > "rdaddr=0x81000000\0" \ > > + "fdt_high=0xffffffff\0" \ > > + "fdtaddr=0x80f80000\0" \ > > "usbtty=cdc_acm\0" \ > > "bootfile=uImage\0" \ > > "ramdisk=ramdisk.gz\0" \ > > @@ -250,6 +252,17 @@ > > "omapdss.def_disp=${defaultdisplay} " \ > > "root=${nandroot} " \ > > "rootfstype=${nandrootfstype}\0" \ > > + "findfdt=" \ > > + "if test $beaglerev = AxBx; then " \ > > + "setenv fdtfile omap3-beagle.dtb; fi; " \ > > + "if test $beaglerev = Cx; then " \ > > + "setenv fdtfile omap3-beagle.dtb; fi; " \ > > + "if test $beaglerev = xMAB; then " \ > > + "setenv fdtfile omap3-beagle-xm.dtb; fi; " \ > > + "if test $beaglerev = xMC; then " \ > > + "setenv fdtfile omap3-beagle-xm.dtb; fi; " \ > > + "if test $fdtfile = undefined; then " \ > > + "echo WARNING: Could not determine device tree to use; fi; \0" \ > > With the remote chance of a future xM rev D, can you make the fallthrough be 'omap3-beagle-xm.dtb' intead of 'undefined'? Lets add the detection of xMD and along with that we add omap3-beagle-xm.dtb detection - makes sense? OR do we assume all un-matched devices default to beagle xMD? what if there was a vanilla beagle rev D? -- Regards, Nishanth Menon