From: Nishanth Menon <nm@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 5/6] omap3_beagle: support findfdt and loadfdt for devicetree support
Date: Mon, 15 Jul 2013 09:06:08 -0500 [thread overview]
Message-ID: <20130715140608.GA24148@kahuna> (raw)
In-Reply-To: <B9359771-45B7-4238-AD93-11BAE499B556@dominion.thruhere.net>
On 15:07-20130715, Koen Kooi wrote:
> Op 15 jul. 2013, om 14:25 heeft Nishanth Menon <nm@ti.com> het volgende geschreven:
> > On 14:16-20130715, Koen Kooi wrote:
> >> Op 15 jul. 2013, om 14:11 heeft Nishanth Menon <nm@ti.com> het volgende geschreven:
> >>
[..]
> >>> + "findfdt=" \
> >>> + "if test $beaglerev = AxBx; then " \
> >>> + "setenv fdtfile omap3-beagle.dtb; fi; " \
> >>> + "if test $beaglerev = Cx; then " \
> >>> + "setenv fdtfile omap3-beagle.dtb; fi; " \
> >>> + "if test $beaglerev = xMAB; then " \
> >>> + "setenv fdtfile omap3-beagle-xm.dtb; fi; " \
> >>> + "if test $beaglerev = xMC; then " \
> >>> + "setenv fdtfile omap3-beagle-xm.dtb; fi; " \
> >>> + "if test $fdtfile = undefined; then " \
> >>> + "echo WARNING: Could not determine device tree to use; fi; \0" \
> >>
> >> With the remote chance of a future xM rev D, can you make the fallthrough be 'omap3-beagle-xm.dtb' intead of 'undefined'?
> > Lets add the detection of xMD and along with that we add
> > omap3-beagle-xm.dtb detection - makes sense? OR do we assume all
> > un-matched devices default to beagle xMD? what if there was a vanilla
> > beagle rev D?
>
> The fallthrough case should always be the most recent board rev, any other way will just make the HW guys spoof the ID in the design and we all know how that ends :(
Fair enough. Anyone else has a contrary opinion?
If none, the following is the replacement patch, wont repost unless a new series
is needed:
next prev parent reply other threads:[~2013-07-15 14:06 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 21:52 [U-Boot] [PATCH 0/5] omap3_beagle: configs: improve BOOT_CMD options Nishanth Menon
2013-07-11 21:52 ` [U-Boot] [PATCH 1/5] omap3_beagle: remove JFFS2 support Nishanth Menon
2013-07-12 2:49 ` Joel Fernandes
2013-07-12 3:49 ` Nishanth Menon
2013-07-12 4:25 ` Joel Fernandes
2013-07-12 4:35 ` Nishanth Menon
2013-07-11 21:52 ` [U-Boot] [PATCH 2/5] omap3_beagle: replace uImage.beagle with generic uImage Nishanth Menon
2013-07-11 21:52 ` [U-Boot] [PATCH 3/5] omap3_beagle: enable CMD_FS_GENERIC and simplify load of image/ramdisk Nishanth Menon
2013-07-11 22:33 ` [U-Boot] [PATCH V2 0/6] omap3_beagle: configs: improve BOOT_CMD options Nishanth Menon
2013-07-11 22:33 ` [U-Boot] [PATCH V2 1/6] omap3_beagle: remove JFFS2 support Nishanth Menon
2013-07-11 22:33 ` [U-Boot] [PATCH V2 2/6] omap3_beagle: replace uImage.beagle with generic uImage Nishanth Menon
2013-07-11 22:33 ` [U-Boot] [PATCH V2 3/6] beagleboard: remove RevB support for BeagleBoard Xm Nishanth Menon
2013-07-11 22:33 ` [U-Boot] [PATCH V2 4/6] omap3_beagle: enable CMD_FS_GENERIC and simplify load of image/ramdisk Nishanth Menon
2013-07-11 22:33 ` [U-Boot] [PATCH V2 5/6] omap3_beagle: support findfdt and loadfdt for devicetree support Nishanth Menon
2013-07-11 22:37 ` Nishanth Menon
2013-07-11 22:33 ` [U-Boot] [PATCH V2 6/6] omap3_beagle: support booting from zImage and device tree as last option Nishanth Menon
2013-07-12 15:10 ` [U-Boot] [PATCH V2 0/6] omap3_beagle: configs: improve BOOT_CMD options Tom Rini
2013-07-15 12:11 ` [U-Boot] [PATCH V3 " Nishanth Menon
2013-07-15 12:11 ` [U-Boot] [PATCH V3 1/6] omap3_beagle: remove JFFS2 support Nishanth Menon
2013-07-15 12:11 ` [U-Boot] [PATCH V3 2/6] omap3_beagle: replace uImage.beagle with generic uImage Nishanth Menon
2013-07-15 12:11 ` [U-Boot] [PATCH V3 3/6] beagleboard: remove RevB support for BeagleBoard Xm Nishanth Menon
2013-07-15 12:11 ` [U-Boot] [PATCH V3 4/6] omap3_beagle: enable CMD_FS_GENERIC and simplify load of image/ramdisk Nishanth Menon
2013-07-15 12:11 ` [U-Boot] [PATCH V3 5/6] omap3_beagle: support findfdt and loadfdt for devicetree support Nishanth Menon
2013-07-15 12:16 ` Koen Kooi
2013-07-15 12:25 ` Nishanth Menon
2013-07-15 13:07 ` Koen Kooi
2013-07-15 14:06 ` Nishanth Menon [this message]
2013-07-15 14:49 ` Tom Rini
2013-07-15 14:52 ` Koen Kooi
2013-07-18 16:13 ` Tom Rini
2013-07-18 18:42 ` Nishanth Menon
2013-07-15 12:11 ` [U-Boot] [PATCH V3 6/6] omap3_beagle: support booting from zImage and device tree as last option Nishanth Menon
2013-07-30 13:29 ` [U-Boot] [PATCH V3 0/6] omap3_beagle: configs: improve BOOT_CMD options Tom Rini
2013-07-11 21:52 ` [U-Boot] [PATCH 4/5] omap3_beagle: support findfdt and loadfdt for devicetree support Nishanth Menon
2013-07-11 22:02 ` Robert Nelson
2013-07-11 22:03 ` Nishanth Menon
2013-07-11 22:05 ` Robert Nelson
2013-07-11 22:17 ` Nishanth Menon
2013-07-11 23:17 ` Robert Nelson
2013-07-12 4:06 ` Nishanth Menon
2013-07-12 13:32 ` Robert Nelson
2013-07-12 14:28 ` Nishanth Menon
2013-07-11 21:52 ` [U-Boot] [PATCH 5/5] omap3_beagle: support booting from zImage and device tree as last option Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130715140608.GA24148@kahuna \
--to=nm@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox