* [U-Boot] [PATCH] usb: ehci-omap: Don't softreset USB High-speed Host (UHH) Module
@ 2013-07-22 8:14 Roger Quadros
2013-07-22 8:46 ` Stefan Roese
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Roger Quadros @ 2013-07-22 8:14 UTC (permalink / raw)
To: u-boot
Fixes NFS root problems with Beagle (3530 ES1.0) when used with
external USB-ethernet adapter and "USB start" command used within
u-boot.
Soft resetting the UHH module causes instability issues on
all OMAPs so we just avoid it.
See OMAP36xx Errata
i571: USB host EHCI may stall when entering smart-standby mode
i660: USBHOST Configured In Smart-Idle Can Lead To a Deadlock
On OMAP4/5, soft-resetting the UHH module can put it into
Smart-Idle mode and lead to a deadlock.
On OMAP3 this doesn't seem to be the case but still instabilities
are observed on beagle (3530 ES1.0) if soft-reset is used.
e.g. NFS root failures with Linux kernel.
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
drivers/usb/host/ehci-omap.c | 27 +++++++++++++++------------
1 files changed, 15 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
index 086c697..0f6ad29 100644
--- a/drivers/usb/host/ehci-omap.c
+++ b/drivers/usb/host/ehci-omap.c
@@ -42,18 +42,21 @@ static struct omap_ehci *const ehci = (struct omap_ehci *)OMAP_EHCI_BASE;
static int omap_uhh_reset(void)
{
- unsigned long init = get_timer(0);
-
- /* perform UHH soft reset, and wait until reset is complete */
- writel(OMAP_UHH_SYSCONFIG_SOFTRESET, &uhh->sysc);
-
- /* Wait for UHH reset to complete */
- while (!(readl(&uhh->syss) & OMAP_UHH_SYSSTATUS_EHCI_RESETDONE))
- if (get_timer(init) > CONFIG_SYS_HZ) {
- debug("OMAP UHH error: timeout resetting ehci\n");
- return -EL3RST;
- }
-
+/*
+ * Soft resetting the UHH module causes instability issues on
+ * all OMAPs so we just avoid it.
+ *
+ * See OMAP36xx Errata
+ * i571: USB host EHCI may stall when entering smart-standby mode
+ * i660: USBHOST Configured In Smart-Idle Can Lead To a Deadlock
+ *
+ * On OMAP4/5, soft-resetting the UHH module will put it into
+ * Smart-Idle mode and lead to a deadlock.
+ *
+ * On OMAP3, this doesn't seem to be the case but still instabilities
+ * are observed on beagle (3530 ES1.0) if soft-reset is used.
+ * e.g. NFS root failures with Linux kernel.
+ */
return 0;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] usb: ehci-omap: Don't softreset USB High-speed Host (UHH) Module
2013-07-22 8:14 [U-Boot] [PATCH] usb: ehci-omap: Don't softreset USB High-speed Host (UHH) Module Roger Quadros
@ 2013-07-22 8:46 ` Stefan Roese
2013-07-22 8:52 ` Marek Vasut
2013-07-24 3:36 ` Marek Vasut
2 siblings, 0 replies; 5+ messages in thread
From: Stefan Roese @ 2013-07-22 8:46 UTC (permalink / raw)
To: u-boot
On 07/22/2013 10:14 AM, Roger Quadros wrote:
> Fixes NFS root problems with Beagle (3530 ES1.0) when used with
> external USB-ethernet adapter and "USB start" command used within
> u-boot.
>
> Soft resetting the UHH module causes instability issues on
> all OMAPs so we just avoid it.
>
> See OMAP36xx Errata
> i571: USB host EHCI may stall when entering smart-standby mode
> i660: USBHOST Configured In Smart-Idle Can Lead To a Deadlock
>
> On OMAP4/5, soft-resetting the UHH module can put it into
> Smart-Idle mode and lead to a deadlock.
>
> On OMAP3 this doesn't seem to be the case but still instabilities
> are observed on beagle (3530 ES1.0) if soft-reset is used.
> e.g. NFS root failures with Linux kernel.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
Thanks a lot for fixing this. With this patch, beagleboard is able to
boot into an NFS root-fs. Even when USB is used previously in U-Boot.
Without this patch NFS booting hangs randomly at some time.
So:
Tested-by: Stefan Roese <sr@denx.de>
Note: I think its a bit too late to take this patch into this release.
So I suggest to apply it in the next merge-window.
Thanks,
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] usb: ehci-omap: Don't softreset USB High-speed Host (UHH) Module
2013-07-22 8:14 [U-Boot] [PATCH] usb: ehci-omap: Don't softreset USB High-speed Host (UHH) Module Roger Quadros
2013-07-22 8:46 ` Stefan Roese
@ 2013-07-22 8:52 ` Marek Vasut
2013-07-23 18:53 ` Dan Murphy
2013-07-24 3:36 ` Marek Vasut
2 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2013-07-22 8:52 UTC (permalink / raw)
To: u-boot
Dear Roger Quadros,
> Fixes NFS root problems with Beagle (3530 ES1.0) when used with
> external USB-ethernet adapter and "USB start" command used within
> u-boot.
>
> Soft resetting the UHH module causes instability issues on
> all OMAPs so we just avoid it.
>
> See OMAP36xx Errata
> i571: USB host EHCI may stall when entering smart-standby mode
> i660: USBHOST Configured In Smart-Idle Can Lead To a Deadlock
>
> On OMAP4/5, soft-resetting the UHH module can put it into
> Smart-Idle mode and lead to a deadlock.
>
> On OMAP3 this doesn't seem to be the case but still instabilities
> are observed on beagle (3530 ES1.0) if soft-reset is used.
> e.g. NFS root failures with Linux kernel.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
Acked-by: Marek Vasut <marex@denx.de>
Now it all depends on Tom, but this would be a last-second save ;-)
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] usb: ehci-omap: Don't softreset USB High-speed Host (UHH) Module
2013-07-22 8:52 ` Marek Vasut
@ 2013-07-23 18:53 ` Dan Murphy
0 siblings, 0 replies; 5+ messages in thread
From: Dan Murphy @ 2013-07-23 18:53 UTC (permalink / raw)
To: u-boot
On 07/22/2013 03:52 AM, Marek Vasut wrote:
> Dear Roger Quadros,
>
>> Fixes NFS root problems with Beagle (3530 ES1.0) when used with
>> external USB-ethernet adapter and "USB start" command used within
>> u-boot.
>>
>> Soft resetting the UHH module causes instability issues on
>> all OMAPs so we just avoid it.
>>
>> See OMAP36xx Errata
>> i571: USB host EHCI may stall when entering smart-standby mode
>> i660: USBHOST Configured In Smart-Idle Can Lead To a Deadlock
>>
>> On OMAP4/5, soft-resetting the UHH module can put it into
>> Smart-Idle mode and lead to a deadlock.
>>
>> On OMAP3 this doesn't seem to be the case but still instabilities
>> are observed on beagle (3530 ES1.0) if soft-reset is used.
>> e.g. NFS root failures with Linux kernel.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
> Acked-by: Marek Vasut <marex@denx.de>
>
> Now it all depends on Tom, but this would be a last-second save ;-)
>
> Best regards,
> Marek Vasut
Tested-by: Dan Murphy <dmurphy@ti.com>
--
------------------
Dan Murphy
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] usb: ehci-omap: Don't softreset USB High-speed Host (UHH) Module
2013-07-22 8:14 [U-Boot] [PATCH] usb: ehci-omap: Don't softreset USB High-speed Host (UHH) Module Roger Quadros
2013-07-22 8:46 ` Stefan Roese
2013-07-22 8:52 ` Marek Vasut
@ 2013-07-24 3:36 ` Marek Vasut
2 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2013-07-24 3:36 UTC (permalink / raw)
To: u-boot
Dear Roger Quadros,
> Fixes NFS root problems with Beagle (3530 ES1.0) when used with
> external USB-ethernet adapter and "USB start" command used within
> u-boot.
>
> Soft resetting the UHH module causes instability issues on
> all OMAPs so we just avoid it.
>
> See OMAP36xx Errata
> i571: USB host EHCI may stall when entering smart-standby mode
> i660: USBHOST Configured In Smart-Idle Can Lead To a Deadlock
>
> On OMAP4/5, soft-resetting the UHH module can put it into
> Smart-Idle mode and lead to a deadlock.
>
> On OMAP3 this doesn't seem to be the case but still instabilities
> are observed on beagle (3530 ES1.0) if soft-reset is used.
> e.g. NFS root failures with Linux kernel.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
Applied, thanks guys for helping me with these omap things.
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-07-24 3:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-22 8:14 [U-Boot] [PATCH] usb: ehci-omap: Don't softreset USB High-speed Host (UHH) Module Roger Quadros
2013-07-22 8:46 ` Stefan Roese
2013-07-22 8:52 ` Marek Vasut
2013-07-23 18:53 ` Dan Murphy
2013-07-24 3:36 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox