public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/7 v9] powerpc: mpc85xx: Support booting from SD Card with SPL
Date: Tue, 23 Jul 2013 12:45:50 +0200	[thread overview]
Message-ID: <20130723104550.25203380CCD@gemini.denx.de> (raw)
In-Reply-To: <1374571024-15729-2-git-send-email-ying.zhang@freescale.com>

Dear ying.zhang at freescale.com,

In message <1374571024-15729-2-git-send-email-ying.zhang@freescale.com> you wrote:
> From: Ying Zhang <b40530@freescale.com>
> 
> This patch introduces SPL to enable a loader stub that being loaded by
> the code from the internal on-chip ROM. It loads the final uboot image
> into DDR, then jump to it to begin execution.
> 
> The SPL's size is sizeable, the maximum size must not exceed the size of L2
> SRAM. It initializes the DDR through SPD code, and copys final uboot image
> to DDR. So there are two stage uboot images:
> 	* spl_boot, 96KB size. The env variables are copied to L2 SRAM, so
> 	that ddr spd code can get the interleaving mode setting in env. It
> 	loads final uboot image from offset 96KB.
> 	* final uboot image, size is variable depends on the functions
> 	enabled.
> 
> Signed-off-by: Ying Zhang <b40530@freescale.com>

So we have reached patch version 9 already, and you still submit code
that is not checkpatch clean?   Please explain how this is possible.

This patch gives:

WARNING: Avoid unnecessary line continuations
#387: FILE: drivers/mmc/fsl_esdhc_spl.c:71:
+       err = mmc->block_dev.block_read(0, CONFIG_CFG_DATA_SECTOR, \

Please fix.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"It follows that any commander in chief who undertakes to carry out a
plan which he considers defective is at fault; he must put forth  his
reasons,  insist  of  the  plan being changed, and finally tender his
resignation rather than be the instrument of his army's downfall."
- Napoleon, "Military Maxims and Thought"

  reply	other threads:[~2013-07-23 10:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23  9:16 [U-Boot] [PATCH 1/7 v9] powerpc: deleted unused symbol CONFIG_SPL_NAND_MINIMAL and enabled some functionality for common SPL ying.zhang at freescale.com
2013-07-23  9:16 ` [U-Boot] [PATCH 2/7 v9] powerpc: mpc85xx: Support booting from SD Card with SPL ying.zhang at freescale.com
2013-07-23 10:45   ` Wolfgang Denk [this message]
2013-07-23  9:17 ` [U-Boot] [PATCH 3/7 v9] powerpc: p1022ds: Enable P1022DS to boot " ying.zhang at freescale.com
2013-07-23 10:47   ` Wolfgang Denk
2013-07-23  9:17 ` [U-Boot] [PATCH 4/7 v9] powerpc : spi flash : Support to start from eSPI " ying.zhang at freescale.com
2013-07-23 10:46   ` Wolfgang Denk
2013-07-23  9:17 ` [U-Boot] [PATCH 5/7 v9] powerpc : p1022ds : enable p1022ds " ying.zhang at freescale.com
2013-07-23  9:17 ` [U-Boot] [PATCH 6/7 v9] NAND: TPL : introduce the TPL based on the SPL ying.zhang at freescale.com
2013-07-23 10:48   ` Wolfgang Denk
2013-07-24  0:21   ` Scott Wood
2013-07-23  9:17 ` [U-Boot] [PATCH 7/7 v9] powerpc: p1022ds: add TPL for p1022ds nand boot ying.zhang at freescale.com
2013-07-23 10:49   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130723104550.25203380CCD@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox