public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/7 v9] powerpc: p1022ds: Enable P1022DS to boot from SD Card with SPL
Date: Tue, 23 Jul 2013 12:47:57 +0200	[thread overview]
Message-ID: <20130723104757.57200380CCD@gemini.denx.de> (raw)
In-Reply-To: <1374571024-15729-3-git-send-email-ying.zhang@freescale.com>

Dear ying.zhang at freescale.com,

In message <1374571024-15729-3-git-send-email-ying.zhang@freescale.com> you wrote:
> From: Ying Zhang <b40530@freescale.com>
> 
> Enable p1022ds to start from eSDHC with SPL.
> 
> Signed-off-by: Ying Zhang <b40530@freescale.com>

Please fix at least the warning:

#243: FILE: board/freescale/p1022ds/spl.c:54:
+       setbits_be32(&gur->pmuxcr,
+               in_be32(&gur->pmuxcr) | MPC85xx_PMUXCR_SD_DATA);

CHECK: Alignment should match open parenthesis
#255: FILE: board/freescale/p1022ds/spl.c:66:
+       NS16550_init((NS16550_t)CONFIG_SYS_NS16550_COM1,
+                       bus_clk / 16 / CONFIG_BAUDRATE);

CHECK: Alignment should match open parenthesis
#265: FILE: board/freescale/p1022ds/spl.c:76:
+       relocate_code(CONFIG_SPL_RELOC_STACK, 0,
+                       CONFIG_SPL_RELOC_TEXT_BASE);

WARNING: Avoid unnecessary line continuations
#283: FILE: board/freescale/p1022ds/spl.c:94:
+       mem_malloc_init(CONFIG_SPL_RELOC_MALLOC_ADDR, \

CHECK: Alignment should match open parenthesis
#322: FILE: board/freescale/p1022ds/tlb.c:100:
+       SET_TLB_ENTRY(1, CONFIG_SYS_INIT_L2_ADDR, CONFIG_SYS_INIT_L2_ADDR_PHYS,
+                       MAS3_SX|MAS3_SW|MAS3_SR, MAS2_G,


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Brain off-line, please wait.

  reply	other threads:[~2013-07-23 10:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23  9:16 [U-Boot] [PATCH 1/7 v9] powerpc: deleted unused symbol CONFIG_SPL_NAND_MINIMAL and enabled some functionality for common SPL ying.zhang at freescale.com
2013-07-23  9:16 ` [U-Boot] [PATCH 2/7 v9] powerpc: mpc85xx: Support booting from SD Card with SPL ying.zhang at freescale.com
2013-07-23 10:45   ` Wolfgang Denk
2013-07-23  9:17 ` [U-Boot] [PATCH 3/7 v9] powerpc: p1022ds: Enable P1022DS to boot " ying.zhang at freescale.com
2013-07-23 10:47   ` Wolfgang Denk [this message]
2013-07-23  9:17 ` [U-Boot] [PATCH 4/7 v9] powerpc : spi flash : Support to start from eSPI " ying.zhang at freescale.com
2013-07-23 10:46   ` Wolfgang Denk
2013-07-23  9:17 ` [U-Boot] [PATCH 5/7 v9] powerpc : p1022ds : enable p1022ds " ying.zhang at freescale.com
2013-07-23  9:17 ` [U-Boot] [PATCH 6/7 v9] NAND: TPL : introduce the TPL based on the SPL ying.zhang at freescale.com
2013-07-23 10:48   ` Wolfgang Denk
2013-07-24  0:21   ` Scott Wood
2013-07-23  9:17 ` [U-Boot] [PATCH 7/7 v9] powerpc: p1022ds: add TPL for p1022ds nand boot ying.zhang at freescale.com
2013-07-23 10:49   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130723104757.57200380CCD@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox