From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 01/10] ARM: move interrupt_init to before relocation
Date: Thu, 25 Jul 2013 10:52:28 +0200 [thread overview]
Message-ID: <20130725105228.2381a087@lilith> (raw)
In-Reply-To: <1371093894-16424-1-git-send-email-robherring2@gmail.com>
Hi Rob,
On Wed, 12 Jun 2013 22:24:45 -0500, Rob Herring <robherring2@gmail.com>
wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> interrupt_init also sets up the abort stack, but is not setup before
> relocation. So any aborts during relocation will hang and not print out
> any useful information. Fix this by moving the interrupt_init to after
> the stack setup in board_init_f.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> ---
> v2:
> - Remove interrupt_init from board_init_r
>
> arch/arm/lib/board.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
> index 09ab4ad..c90843e 100644
> --- a/arch/arm/lib/board.c
> +++ b/arch/arm/lib/board.c
> @@ -447,6 +447,7 @@ void board_init_f(ulong bootflag)
> addr_sp += 128; /* leave 32 words for abort-stack */
> gd->irq_sp = addr_sp;
> #endif
> + interrupt_init();
>
> debug("New Stack Pointer is: %08lx\n", addr_sp);
>
> @@ -648,8 +649,6 @@ void board_init_r(gd_t *id, ulong dest_addr)
> misc_init_r();
> #endif
>
> - /* set up exceptions */
> - interrupt_init();
> /* enable exceptions */
> enable_interrupts();
>
Whole series applied to u-boot-arm/master, thanks!
Amicalement,
--
Albert.
prev parent reply other threads:[~2013-07-25 8:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 3:24 [U-Boot] [PATCH v2 01/10] ARM: move interrupt_init to before relocation Rob Herring
2013-06-13 3:24 ` [U-Boot] [PATCH v2 02/10] net: calxedaxgmac: enable rx cut-thru Rob Herring
2013-06-13 3:24 ` [U-Boot] [PATCH v2 03/10] ARM: highbank: update config options Rob Herring
2013-06-13 3:24 ` [U-Boot] [PATCH v2 04/10] ARM: highbank: fix get_tbclk value to timer rate Rob Herring
2013-06-13 3:24 ` [U-Boot] [PATCH v2 05/10] ARM: highbank: set timer prescaler to 256 Rob Herring
2013-06-13 3:24 ` [U-Boot] [PATCH v2 06/10] ARM: highbank: avoid bss write in timer_init Rob Herring
2013-06-13 3:24 ` [U-Boot] [PATCH v2 07/10] ARM: highbank: enable reset on command timeout Rob Herring
2013-06-13 3:24 ` [U-Boot] [PATCH v2 08/10] ARM: highbank: setup peripherals based on power domain status Rob Herring
2013-06-13 3:24 ` [U-Boot] [PATCH v2 09/10] ARM: highbank: compile misc_init_r only if CONFIG_MISC_INIT_R Rob Herring
2013-06-13 3:24 ` [U-Boot] [PATCH v2 10/10] highbank: enable keyed autoboot stop Rob Herring
2013-07-25 8:52 ` Albert ARIBAUD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130725105228.2381a087@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox