public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] Remove static display data
Date: Fri, 26 Jul 2013 09:50:49 +0200	[thread overview]
Message-ID: <20130726095049.3ee4a02e@crub> (raw)
In-Reply-To: <CAMDMJ5O6U-sDObxYW3PnBr=O5a1+Ey_WC1N47G_A-oUeSfu9JA@mail.gmail.com>

Hello Robert,

On Thu, 25 Jul 2013 11:21:10 -0700
Robert Winkler <robert.winkler@boundarydevices.com> wrote:

> Hello all,
> 
> We're trying to figure out how best to get rid of static code like this:
> 
> http://git.denx.de/?p=u-boot.git;a=blob;f=board/boundary/nitrogen6x/nitrogen6x.c;h=8f0f9b8de2e8e77fcbf477728ea063a213941dd0;hb=HEAD#l526
> 
> and turn it into run time data.
> 
> Our idea is to use an environment variable so adding support for new
> screens and iterating on minor settings is quick and easy and then we can
> remove the static arrays like the one above and in wandboard.c and other
> places.

We have some code and users to define timing parameters in an environment
variable "videomode". video_get_params() is used to read the parameters
into a structure "struct ctfb_res_modes".

> One way to do this is to create a data structure that can subsume the
> functionalities of of display_info_t and the various structures in lcd.h
> and elsewhere that can be used throughout U-Boot both with CONFIG_LCD and
> CONFIG_CFB_CONSOLE.  Combined with the EDID functionality already in U-Boot
> this would allow code to easily select the "best" display supported by the
> monitor or closest to what the user wanted (given in the environment
> variable).  This data structure would then be passed to Linux on boot up.
>
> I realize that there's already the FDT and CONFIG_OF_CONTROL functionality
> and device trees sort of cover the passing to Linux part so maybe before
> handing it off, converting the relevant data into a device tree that Linux
> can already use/parse would work.

Devicetree bindings for describing display timings info exist in recent
Linux kernel versions (since v3.9 I think) and are documented under
Documentation/devicetree/bindings/video/display-timing.txt. In Linux
there are also DT helpers to parse display timings nodes and read the
timing values into fb_videomode structure (of_get_display_timings,
of_get_fb_videomode). Code for adding such display timings nodes to
the device tree under U-Boot doesn't exist yet.

> Is anyone working on something like this?  Am I missing something that's
> already in place to accomplish this?

Maybe you can use "videomode" Variable and video_get_params().

Thanks,

Anatolij

  reply	other threads:[~2013-07-26  7:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25 18:21 [U-Boot] [RFC] Remove static display data Robert Winkler
2013-07-26  7:50 ` Anatolij Gustschin [this message]
2013-07-26  8:43   ` Stefano Babic
2013-07-26 14:04     ` Eric Nelson
2013-07-26 14:42       ` Stefano Babic
2013-07-26 14:49         ` Stephen Warren
2013-07-26 19:41           ` Eric Nelson
2013-07-27  0:42         ` Eric Nelson
2013-07-27  1:34           ` Troy Kisky
2013-07-27 19:05           ` Simon Glass
2013-07-28 16:57             ` Eric Nelson
2013-07-28 18:09               ` Simon Glass
2013-07-28 19:22                 ` Eric Nelson
2013-07-29 16:50                   ` Simon Glass
2013-07-26 14:00   ` Eric Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130726095049.3ee4a02e@crub \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox