public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] video: mxc_ipuv3: fix memory alignment of framebuffer
Date: Fri, 26 Jul 2013 21:38:53 +0200	[thread overview]
Message-ID: <201307262138.53588.marex@denx.de> (raw)
In-Reply-To: <51F28935.7000905@boundarydevices.com>

Dear Eric Nelson,

> Hi Marek,
> 
> On 07/25/2013 09:27 PM, Marek Vasut wrote:
> > Dear Eric Nelson,
> > 
> >> The frame-buffer on i.MX boards needs to be aligned for DMA.
> >> 
> >> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> >> ---
> >> 
> >>   drivers/video/mxc_ipuv3_fb.c | 3 ++-
> >>   1 file changed, 2 insertions(+), 1 deletion(-)
> >> 
> >> diff --git a/drivers/video/mxc_ipuv3_fb.c b/drivers/video/mxc_ipuv3_fb.c
> >> index ace226c..ad95831 100644
> >> --- a/drivers/video/mxc_ipuv3_fb.c
> >> +++ b/drivers/video/mxc_ipuv3_fb.c
> >> @@ -416,7 +416,8 @@ static int mxcfb_map_video_memory(struct fb_info
> >> *fbi)
> >> 
> >>   				    fbi->fix.line_length;
> >>   	
> >>   	}
> >> 
> >> -	fbi->screen_base = (char *)malloc(fbi->fix.smem_len);
> >> +	fbi->screen_base = (char *)memalign(ARCH_DMA_MINALIGN,
> >> +					    fbi->fix.smem_len);
> > 
> > You might want to round-up the length too, like I did in the MXS driver.
> 
> Did you really run across a display whose size wasn't a multiple of
> 32, or is this rounding just in muscle-memory for you?

Palm devices with PXA27x (PalmT5, PalmLD, PalmTX) had 484x324 LCDs ;-)

Best regards,
Marek Vasut

  reply	other threads:[~2013-07-26 19:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-26  0:35 [U-Boot] [PATCH] video: mxc_ipuv3: fix memory alignment of framebuffer Eric Nelson
2013-07-26  4:27 ` Marek Vasut
2013-07-26 14:35   ` Eric Nelson
2013-07-26 19:38     ` Marek Vasut [this message]
2013-07-27  0:56       ` Eric Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201307262138.53588.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox