From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Fri, 26 Jul 2013 21:38:53 +0200
Subject: [U-Boot] [PATCH] video: mxc_ipuv3: fix memory alignment of
	framebuffer
In-Reply-To: <51F28935.7000905@boundarydevices.com>
References: <1374798926-18743-1-git-send-email-eric.nelson@boundarydevices.com>
	<201307260627.10732.marex@denx.de>
	<51F28935.7000905@boundarydevices.com>
Message-ID: <201307262138.53588.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Eric Nelson,

> Hi Marek,
> 
> On 07/25/2013 09:27 PM, Marek Vasut wrote:
> > Dear Eric Nelson,
> > 
> >> The frame-buffer on i.MX boards needs to be aligned for DMA.
> >> 
> >> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> >> ---
> >> 
> >>   drivers/video/mxc_ipuv3_fb.c | 3 ++-
> >>   1 file changed, 2 insertions(+), 1 deletion(-)
> >> 
> >> diff --git a/drivers/video/mxc_ipuv3_fb.c b/drivers/video/mxc_ipuv3_fb.c
> >> index ace226c..ad95831 100644
> >> --- a/drivers/video/mxc_ipuv3_fb.c
> >> +++ b/drivers/video/mxc_ipuv3_fb.c
> >> @@ -416,7 +416,8 @@ static int mxcfb_map_video_memory(struct fb_info
> >> *fbi)
> >> 
> >>   				    fbi->fix.line_length;
> >>   	
> >>   	}
> >> 
> >> -	fbi->screen_base = (char *)malloc(fbi->fix.smem_len);
> >> +	fbi->screen_base = (char *)memalign(ARCH_DMA_MINALIGN,
> >> +					    fbi->fix.smem_len);
> > 
> > You might want to round-up the length too, like I did in the MXS driver.
> 
> Did you really run across a display whose size wasn't a multiple of
> 32, or is this rounding just in muscle-memory for you?

Palm devices with PXA27x (PalmT5, PalmLD, PalmTX) had 484x324 LCDs ;-)

Best regards,
Marek Vasut