From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] config.mk: Add -Wundef to CFLAGS
Date: Tue, 30 Jul 2013 14:07:16 +0200 [thread overview]
Message-ID: <20130730140716.17ffa50e@lilith> (raw)
In-Reply-To: <1375153025-20147-1-git-send-email-yamada.m@jp.panasonic.com>
Hi Masahiro,
On Tue, 30 Jul 2013 11:57:05 +0900, Masahiro Yamada
<yamada.m@jp.panasonic.com> wrote:
> In U-boot source, some '#if' directives evaluate
> undefined identifiers.
>
> To find and fix them, this commit adds -Wundef to CFLAGS.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
> config.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config.mk b/config.mk
> index f71e145..7a92ae3 100644
> --- a/config.mk
> +++ b/config.mk
> @@ -259,7 +259,7 @@ CPPFLAGS += -I$(TOPDIR)/include
> CPPFLAGS += -fno-builtin -ffreestanding -nostdinc \
> -isystem $(gccincdir) -pipe $(PLATFORM_CPPFLAGS)
>
> -CFLAGS := $(CPPFLAGS) -Wall -Wstrict-prototypes
> +CFLAGS := $(CPPFLAGS) -Wall -Wstrict-prototypes -Wundef
>
> ifdef BUILD_TAG
> CFLAGS += -DBUILD_TAG='"$(BUILD_TAG)"'
Will the patch cause some targets to break? If so, then I personally
would prefer that fixes be provided for at least the trivial cases.
Amicalement,
--
Albert.
next prev parent reply other threads:[~2013-07-30 12:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 2:57 [U-Boot] [PATCH] config.mk: Add -Wundef to CFLAGS Masahiro Yamada
2013-07-30 12:07 ` Albert ARIBAUD [this message]
2013-07-31 2:45 ` Masahiro Yamada
2013-07-31 7:26 ` Albert ARIBAUD
2013-08-21 4:33 ` Masahiro Yamada
2013-10-02 19:27 ` Albert ARIBAUD
2013-10-03 23:49 ` Simon Glass
2013-10-05 7:04 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730140716.17ffa50e@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox