From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Tue, 30 Jul 2013 14:07:16 +0200
Subject: [U-Boot] [PATCH] config.mk: Add -Wundef to CFLAGS
In-Reply-To: <1375153025-20147-1-git-send-email-yamada.m@jp.panasonic.com>
References: <1375153025-20147-1-git-send-email-yamada.m@jp.panasonic.com>
Message-ID: <20130730140716.17ffa50e@lilith>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Masahiro,

On Tue, 30 Jul 2013 11:57:05 +0900, Masahiro Yamada
<yamada.m@jp.panasonic.com> wrote:

> In U-boot source, some '#if' directives evaluate
> undefined identifiers.
> 
> To find and fix them, this commit adds -Wundef to CFLAGS.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
>  config.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config.mk b/config.mk
> index f71e145..7a92ae3 100644
> --- a/config.mk
> +++ b/config.mk
> @@ -259,7 +259,7 @@ CPPFLAGS += -I$(TOPDIR)/include
>  CPPFLAGS += -fno-builtin -ffreestanding -nostdinc	\
>  	-isystem $(gccincdir) -pipe $(PLATFORM_CPPFLAGS)
>  
> -CFLAGS := $(CPPFLAGS) -Wall -Wstrict-prototypes
> +CFLAGS := $(CPPFLAGS) -Wall -Wstrict-prototypes -Wundef
>  
>  ifdef BUILD_TAG
>  CFLAGS += -DBUILD_TAG='"$(BUILD_TAG)"'

Will the patch cause some targets to break? If so, then I personally
would prefer that fixes be provided for at least the trivial cases.

Amicalement,
-- 
Albert.