From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 31 Jul 2013 01:36:34 +0200 Subject: [U-Boot] [PATCH 05/11] ARM: mxs: Add Creative ZEN XFi3 board In-Reply-To: References: <1375220281-11132-1-git-send-email-marex@denx.de> <201307310046.58063.marex@denx.de> Message-ID: <201307310136.34877.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Otavio Salvador, > On Tue, Jul 30, 2013 at 7:46 PM, Marek Vasut wrote: > > Dear Otavio Salvador, > > > > [...] > > > >> > + mxsfb_write_register(0x36, 0xaf); > >> > + mxsfb_write_register(0x37, 0); > >> > + mxsfb_write_register(0x38, 0xdb); > >> > + mxsfb_write_register(0x39, 0); > >> > + mxsfb_write_register(0x20, 0); > >> > + mxsfb_write_register(0x21, 0); > >> > + /* Turn on Framebuffer Upload Mode */ > >> > + mxsfb_write_byte(0x22, 0); > >> > >> Where does those values come from? > > > > The panel datasheet and from Amaury. > > > > [...] > > > > It'd be nice if you learnt to cut down the email to the relevant part > > only when replying. > > Couldn't this use macros to make it easier to read What kind of macros ? Using function call allows the compiler to do type- checking on the data, so no, using macro would be sub-par. > or at least a > comment informing where to find those? See OTM2201A datasheet for the finer details, yet it will be useless for you since this is rather device-specific configuration. Best regards, Marek Vasut