public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 06/20] usb: gadget: mv_udc: fix hardware udc address for i.MX6
Date: Fri, 2 Aug 2013 12:53:42 +0200	[thread overview]
Message-ID: <201308021253.42563.marex@denx.de> (raw)
In-Reply-To: <1375399657-25642-7-git-send-email-troy.kisky@boundarydevices.com>

Dear Troy Kisky,

> The hcor for i.MX6 is 02184340
> and the udc should be 02184140
> 
> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> 
> ---
> I don't know if this is a correct fix, please check carefully.
> ---
>  drivers/usb/gadget/mv_udc.c | 28 +++++++++++++++++++---------
>  1 file changed, 19 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/usb/gadget/mv_udc.c b/drivers/usb/gadget/mv_udc.c
> index 7574e31..359b8e1 100644
> --- a/drivers/usb/gadget/mv_udc.c
> +++ b/drivers/usb/gadget/mv_udc.c
> @@ -110,6 +110,16 @@ static struct mv_drv controller = {
>  	},
>  };
> 
> +struct mv_udc *get_mv_udc(void)
> +{
> +#ifdef CONFIG_MXC_USB_PORT
> +	return (struct mv_udc *)((unsigned)controller.ctrl->hcor
> +			- (0x200 * CONFIG_MXC_USB_PORT));
> +#else
> +	return (struct mv_udc *)controller.ctrl->hcor;
> +#endif
> +}
> +

This in particular is something I wanted to avoid happening.

Can you instead call

usb_lowlevel_init(0, (void **)&controller.ctrl);

for different number than 0 in usb_gadget_register_driver() instead ? THe effect 
will be the same, yet the patch will be smaller.

Best regards,
Marek Vasut

  reply	other threads:[~2013-08-02 10:53 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-01 23:27 [U-Boot] [PATCH V3 00/20] Make mv_udc work for i.mx6 Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 01/20] Add functions for use with i.mx6 otg udc Troy Kisky
2013-08-02 10:48   ` Marek Vasut
2013-08-02 19:44     ` Troy Kisky
2013-08-02 22:10       ` Marek Vasut
2013-08-02 23:41         ` Troy Kisky
2013-08-03  1:45           ` Marek Vasut
2013-08-03  2:24             ` Troy Kisky
2013-08-03 16:47               ` Marek Vasut
2013-08-03 19:30                 ` Troy Kisky
2013-08-03 22:46                   ` Marek Vasut
2013-08-15 21:36                   ` Marek Vasut
2013-08-16 18:20                     ` Troy Kisky
2013-08-04 20:15   ` Wolfgang Denk
2013-08-05 20:15     ` Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 02/20] mx6: iomux: add GPR1 defines Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 03/20] nitrogen6x: add otg usb ethernet gadget support Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 04/20] nitrogen6x: add CONFIG_MV_UDC Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 05/20] arch-mxs/sys_proto.h: include regs-common.h Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 06/20] usb: gadget: mv_udc: fix hardware udc address for i.MX6 Troy Kisky
2013-08-02 10:53   ` Marek Vasut [this message]
2013-08-01 23:27 ` [U-Boot] [PATCH V3 07/20] usb: gadget: config: fix unaligned access issues Troy Kisky
2013-08-02 10:57   ` Marek Vasut
2013-08-01 23:27 ` [U-Boot] [PATCH V3 08/20] usb: gadget: mv_udc: add MX6Q specific reset Troy Kisky
2013-08-02 10:58   ` Marek Vasut
2013-08-01 23:27 ` [U-Boot] [PATCH V3 09/20] usb: gadget: ether set wMaxPacketSize Troy Kisky
2013-08-02 10:59   ` Marek Vasut
2013-08-01 23:27 ` [U-Boot] [PATCH V3 10/20] usb: gadget: ether: return error from rx_submit if no request Troy Kisky
2013-08-02 11:07   ` Marek Vasut
2013-08-01 23:27 ` [U-Boot] [PATCH V3 11/20] usb: gadget: mv_udc: split mv_udc.h file Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 12/20] usb: udc: add udc.h include file Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 13/20] usb: gadget: mv_udc: fix typo in error message Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 14/20] usb: gadget: mv_udc: set is_dualspeed = 1 Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 15/20] usb: gadget: mv_udc: fix full speed connections Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 16/20] usb: gadget: mv_udc: optimize bounce Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 17/20] usb: gadget: mv_udc: flush item before head Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 18/20] usb: gadget: mv_udc: optimize ep_enable Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 19/20] usb: gadget: mv_udc: zero transfer descriptor memory on probe Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 20/20] usb: gadget: mv_udc: clear desc upon ep_disable Troy Kisky
2013-08-02 11:14 ` [U-Boot] [PATCH V3 00/20] Make mv_udc work for i.mx6 Marek Vasut
2013-08-02 14:43 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201308021253.42563.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox