From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Fri, 2 Aug 2013 12:53:42 +0200
Subject: [U-Boot] [PATCH V3 06/20] usb: gadget: mv_udc: fix hardware udc
	address for i.MX6
In-Reply-To: <1375399657-25642-7-git-send-email-troy.kisky@boundarydevices.com>
References: <1375399657-25642-1-git-send-email-troy.kisky@boundarydevices.com>
	<1375399657-25642-7-git-send-email-troy.kisky@boundarydevices.com>
Message-ID: <201308021253.42563.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Troy Kisky,

> The hcor for i.MX6 is 02184340
> and the udc should be 02184140
> 
> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> 
> ---
> I don't know if this is a correct fix, please check carefully.
> ---
>  drivers/usb/gadget/mv_udc.c | 28 +++++++++++++++++++---------
>  1 file changed, 19 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/usb/gadget/mv_udc.c b/drivers/usb/gadget/mv_udc.c
> index 7574e31..359b8e1 100644
> --- a/drivers/usb/gadget/mv_udc.c
> +++ b/drivers/usb/gadget/mv_udc.c
> @@ -110,6 +110,16 @@ static struct mv_drv controller = {
>  	},
>  };
> 
> +struct mv_udc *get_mv_udc(void)
> +{
> +#ifdef CONFIG_MXC_USB_PORT
> +	return (struct mv_udc *)((unsigned)controller.ctrl->hcor
> +			- (0x200 * CONFIG_MXC_USB_PORT));
> +#else
> +	return (struct mv_udc *)controller.ctrl->hcor;
> +#endif
> +}
> +

This in particular is something I wanted to avoid happening.

Can you instead call

usb_lowlevel_init(0, (void **)&controller.ctrl);

for different number than 0 in usb_gadget_register_driver() instead ? THe effect 
will be the same, yet the patch will be smaller.

Best regards,
Marek Vasut