From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Fri, 2 Aug 2013 13:07:58 +0200
Subject: [U-Boot] [PATCH V3 10/20] usb: gadget: ether: return error from
	rx_submit if no request
In-Reply-To: <1375399657-25642-11-git-send-email-troy.kisky@boundarydevices.com>
References: <1375399657-25642-1-git-send-email-troy.kisky@boundarydevices.com>
	<1375399657-25642-11-git-send-email-troy.kisky@boundarydevices.com>
Message-ID: <201308021307.58517.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Troy Kisky,

> This prevents a crash if tftpboot is given a bad filename.

How is bad filename related to struct usb_request?

> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> ---
>  drivers/usb/gadget/ether.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c
> index f583c6e..fe73c7b 100644
> --- a/drivers/usb/gadget/ether.c
> +++ b/drivers/usb/gadget/ether.c
> @@ -1535,6 +1535,8 @@ static int rx_submit(struct eth_dev *dev, struct
> usb_request *req, */
> 
>  	debug("%s\n", __func__);
> +	if (!req)
> +		return -EINVAL;
> 
>  	size = (ETHER_HDR_SIZE + dev->mtu + RX_EXTRA);
>  	size += dev->out_ep->maxpacket - 1;

Best regards,
Marek Vasut