From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Mac address warning
Date: Fri, 2 Aug 2013 10:45:04 -0400 [thread overview]
Message-ID: <20130802144504.GD5164@bill-the-cat> (raw)
In-Reply-To: <51FBC3E7.7090506@denx.de>
On Fri, Aug 02, 2013 at 04:36:23PM +0200, Stefano Babic wrote:
> Hi Tom,
>
> On 02/08/2013 16:16, Tom Rini wrote:
> >> Well, I have found it very useful in case I set explicitely the
> >> ethaddr variable, so I know where the MAC address comes from. Do
> >> you find it disturbing ? Maybe we could replace "warning" with
> >> "info".
> >
> > On am335x the message we use is: <ethaddr> not set. Validating
> > first E-fuse MAC And then validate it, and setenv.
> >
> ..but the code is common as it is located in net/eth.c. The warning
> does not depend on the SOC.
Does it even belong there? It looks like some generally unused and
dangling functionality, the "write" portion that is. A number of
drivers do set write_hwaddr, but only usb_ether calls it, and not in an
update the HW fashion...
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130802/14c3b9f3/attachment.pgp>
next prev parent reply other threads:[~2013-08-02 14:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 23:28 [U-Boot] Mac address warning Eric Nelson
2013-08-02 13:08 ` Stefano Babic
2013-08-02 14:16 ` Tom Rini
2013-08-02 14:36 ` Stefano Babic
2013-08-02 14:45 ` Tom Rini [this message]
2013-08-02 14:39 ` Eric Nelson
2013-08-04 20:24 ` Wolfgang Denk
2013-08-04 20:37 ` Eric Nelson
2013-08-04 20:17 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130802144504.GD5164@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox