From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/4] arm, am33xx: add defines for gmii_sel_register bits
Date: Mon, 12 Aug 2013 10:22:09 -0400 [thread overview]
Message-ID: <20130812142209.GF5164@bill-the-cat> (raw)
In-Reply-To: <51F8ACAE.8000103@denx.de>
On Wed, Jul 31, 2013 at 08:20:30AM +0200, Heiko Schocher wrote:
> Hello Mugunthan,
>
> Am 30.07.2013 10:40, schrieb Mugunthan V N:
> >On 7/30/2013 1:23 PM, Heiko Schocher wrote:
> >>Signed-off-by: Heiko Schocher<hs@denx.de>
> >>
> >>---
> >>- changes for v2:
> >> defined all bits used in the gmii_sel register as
> >> Tom Rini suggested
> >>- changes for v3:
> >> rebased against u-boot-ti commit bb2a5d8f87fffb4fadfb205837decbd1b3e75f88
> >>---
> >> arch/arm/include/asm/arch-am33xx/cpu.h | 21 +++++++++++++++++++++
> >> board/isee/igep0033/board.c | 6 ++----
> >> board/phytec/pcm051/board.c | 2 --
> >> board/ti/am335x/board.c | 6 +-----
> >> 4 Dateien ge??ndert, 24 Zeilen hinzugef??gt(+), 11 Zeilen entfernt(-)
> >>
> >>diff --git a/arch/arm/include/asm/arch-am33xx/cpu.h b/arch/arm/include/asm/arch-am33xx/cpu.h
> >>index bcb4c50..945a09b 100644
> >>--- a/arch/arm/include/asm/arch-am33xx/cpu.h
> >>+++ b/arch/arm/include/asm/arch-am33xx/cpu.h
> >>@@ -336,6 +336,27 @@ struct ctrl_dev {
> >> unsigned int resv4[4];
> >> unsigned int miisel; /* offset 0x50 */
> >> };
> >>+
> >>+/* gmii_sel register defines */
> >>+#define GMII1_SEL_MII 0x0
> >>+#define GMII1_SEL_RMII 0x1
> >>+#define GMII1_SEL_RGMII 0x2
> >>+#define GMII1_SEL_NOTUSED 0x3
> >NOTUSED not needed as it is not supposed to be used.
>
> Maybe it is used to check, that is it not set?
> But I can remove it ...
>
> >>+#define GMII2_SEL_MII 0x0
> >>+#define GMII2_SEL_RMII 0x4
> >>+#define GMII2_SEL_RGMII 0x8
> >>+#define GMII2_SEL_NOTUSED 0xc
> >NOTUSED not needed as it is not supposed to be used.
>
> same here ...
I think "Not Used" in the TRM here means "this port is not used" rather
than "this combination of bits is not to be used", so the changes are
correct.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130812/6a6faa3f/attachment.pgp>
next prev parent reply other threads:[~2013-08-12 14:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 7:53 [U-Boot] [PATCH v3 0/4] arm, am335x: add support for siemens boards Heiko Schocher
2013-07-30 7:53 ` [U-Boot] [PATCH v3 1/4] arm, am33xx: add defines for gmii_sel_register bits Heiko Schocher
2013-07-30 8:40 ` Mugunthan V N
2013-07-31 6:20 ` Heiko Schocher
2013-08-12 14:22 ` Tom Rini [this message]
2013-08-12 17:36 ` Mugunthan V N
2013-08-14 6:29 ` Mugunthan V N
2013-08-14 13:51 ` Tom Rini
2013-07-30 7:53 ` [U-Boot] [PATCH v3 2/4] arm, spl: add watchdog library to SPL Heiko Schocher
2013-07-30 7:53 ` [U-Boot] [PATCH v3 3/4] arm, am335x: add watchdog support Heiko Schocher
2013-07-30 7:53 ` [U-Boot] [PATCH v3 4/4] arm, am335x: add support for 3 siemens boards Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130812142209.GF5164@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox