From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v8 RESEND 2/2] console: usb: kbd: To improve TFTP booting performance
Date: Mon, 12 Aug 2013 22:13:43 +0200 [thread overview]
Message-ID: <201308122213.43328.marex@denx.de> (raw)
In-Reply-To: <52090371.6000209@wwwdotorg.org>
Dear Stephen Warren,
> On 08/11/2013 12:08 PM, Marek Vasut wrote:
> > Dear Jim Lin,
> >
> >> TFTP booting is slow when a USB keyboard is installed and
> >> stdin has usbkbd added.
> >> This fix is to change Ctrl-C polling for USB keyboard to every second
> >> when NET transfer is running.
> >>
> >> diff --git a/include/usb.h b/include/usb.h
> >>
> >> +extern int __maybe_unused net_busy_flag;
> >
> > I wonder what would happen if you declared it here as
> >
> > static int __maybe_unused
> >
> > Would it have some side-effects?
>
> Then each file that includes this header will get a separate copy of the
> variable.
Ah, you're right.
Best regards,
Marek Vasut
prev parent reply other threads:[~2013-08-12 20:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 12:33 [U-Boot] [PATCH v8 RESEND 2/2] console: usb: kbd: To improve TFTP booting performance Jim Lin
2013-08-11 18:08 ` Marek Vasut
2013-08-12 15:46 ` Stephen Warren
2013-08-12 20:13 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201308122213.43328.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox