public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] serial: arm_dcc: Convert to use default_serial_puts
Date: Sun, 18 Aug 2013 22:19:16 +0200	[thread overview]
Message-ID: <201308182219.17158.marex@denx.de> (raw)
In-Reply-To: <1376725174.15462.1.camel@phoenix>

Dear Axel Lin,

> Use default_serial_puts() instead of its own implementation.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Thanks,

Acked-by: Marek Vasut <marex@denx.de>

> ---
>  drivers/serial/arm_dcc.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/serial/arm_dcc.c b/drivers/serial/arm_dcc.c
> index 29d9295..5dfb02f 100644
> --- a/drivers/serial/arm_dcc.c
> +++ b/drivers/serial/arm_dcc.c
> @@ -123,12 +123,6 @@ static void arm_dcc_putc(char ch)
>  		write_dcc(ch);
>  }
> 
> -static void arm_dcc_puts(const char *s)
> -{
> -	while (*s)
> -		arm_dcc_putc(*s++);
> -}
> -
>  static int arm_dcc_tstc(void)
>  {
>  	register unsigned int reg;
> @@ -148,7 +142,7 @@ static struct serial_device arm_dcc_drv = {
>  	.stop	= NULL,
>  	.setbrg	= arm_dcc_setbrg,
>  	.putc	= arm_dcc_putc,
> -	.puts	= arm_dcc_puts,
> +	.puts	= default_serial_puts,
>  	.getc	= arm_dcc_getc,
>  	.tstc	= arm_dcc_tstc,
>  };

Best regards,
Marek Vasut

  reply	other threads:[~2013-08-18 20:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-17  7:39 [U-Boot] [PATCH] serial: arm_dcc: Convert to use default_serial_puts Axel Lin
2013-08-18 20:19 ` Marek Vasut [this message]
2013-08-19  5:30   ` Michal Simek
2013-08-19 13:49 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201308182219.17158.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox