From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Mon, 26 Aug 2013 18:28:07 +0200
Subject: [U-Boot] [PATCH v9 2/2] console: usb: kbd: To improve TFTP
	booting performance
In-Reply-To: <521B7CB7.6020402@wwwdotorg.org>
References: <1376391862-28686-1-git-send-email-jilin@nvidia.com>
	<201308261331.59684.marex@denx.de> <521B7CB7.6020402@wwwdotorg.org>
Message-ID: <201308261828.07402.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Stephen Warren,

> On 08/26/2013 05:31 AM, Marek Vasut wrote:
> > Dear Jim Lin,
> > 
> >> Marek,
> >> In common/usb_kbd.c, you applied code to wrong place.
> >> You should apply my change to function usb_kbd_testc(), instead of
> >> usb_kbd_getc(). Could you help to correct it?
> > 
> > I believe I applied your patches. Anyway, submit a subsequent patch
> > against u- boot-usb/master please.
> 
> Marek, did you apply the patch using "git am", "patch", or by
> hand-editing? Looking at the fixup patch that Jim sent, the patch
> context is identical in both places, so perhaps this exposed some issue
> with git/... - it'd be useful to understand how the problem occurred, so
> it can be fixed.

git am ... and you're right, this is somewhat strange.

Best regards,
Marek Vasut