public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Luka Perkov <luka@openwrt.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] fw_env: add redundand env support for MTD_ABSENT
Date: Wed, 28 Aug 2013 01:03:54 +0200	[thread overview]
Message-ID: <20130827230354-6496@mutt-kz> (raw)
In-Reply-To: <20130827173557.4C5C811C0ED4@dd12814.kasserver.com>

Hi Oliver,

On Tue, Aug 27, 2013 at 07:35:57PM +0200, Oliver Metz wrote:
> But I'm unsure how to comment the changes in fw_env.config since redundant
> env description is already in the comment at the top.
> 
> Is something like this enough?
> 
> diff --git a/tools/env/fw_env.config b/tools/env/fw_env.config
> index 90e499d..fcaab55 100644
> --- a/tools/env/fw_env.config
> +++ b/tools/env/fw_env.config
> @@ -20,3 +20,4 @@
>  
>  # Block device example
>  #/dev/mmcblk0          0xc0000         0x20000
> +#/dev/mmcblk0          0xe0000         0x20000

I'd say it's unnecessary...

Luka

      reply	other threads:[~2013-08-27 23:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-25 12:46 [U-Boot] [PATCH 1/2] fw_env: add redundand env support for MTD_ABSENT Oliver Metz
2013-08-25 12:46 ` [U-Boot] [PATCH 2/2] fw_env: fix writing environment for mtd devices Oliver Metz
2013-08-26 14:25 ` [U-Boot] [PATCH 1/2] fw_env: add redundand env support for MTD_ABSENT Robert P. J. Day
2013-08-27 17:35   ` Oliver Metz
2013-08-27 23:03     ` Luka Perkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130827230354-6496@mutt-kz \
    --to=luka@openwrt.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox