From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 28 Aug 2013 10:40:34 +0200 Subject: [U-Boot] [PATCH 3/3 V2] ARM: mxs: Fix NAND FCB flashing In-Reply-To: <1377640181-5459-1-git-send-email-marex@denx.de> References: <1377639159-5243-3-git-send-email-marex@denx.de> <1377640181-5459-1-git-send-email-marex@denx.de> Message-ID: <201308281040.34486.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Marek Vasut, > Fix the method of flashing FCB blocks into NAND. The new env > writes all four FCB blocks and also does not scrub such a big > part of the NAND. This fixed complains about busted NAND blocks > in Linux. > > Signed-off-by: Marek Vasut > Cc: Fabio Estevam > Cc: Stefano Babic > --- > include/configs/m28evk.h | 23 +++++++++++++++++++++-- > include/configs/mx28evk.h | 23 +++++++++++++++++++++-- > 2 files changed, 42 insertions(+), 4 deletions(-) > > V2: Write the whole stride (64 pages) in the FCB case, not only one page. > > diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h > index eba8759..6e1ecbe 100644 > --- a/include/configs/m28evk.h > +++ b/include/configs/m28evk.h > @@ -170,11 +170,30 @@ > "nand info ; " \ > "setexpr fcb_sz ${update_nand_stride} * ${update_nand_count};" \ > "setexpr update_nand_fcb ${fcb_sz} * ${nand_writesize}\0" \ > + "update_nand_write_fcb=" \ > + "setenv i ${update_nand_count} ; " \ > + "setenv update_nand_offset 0x0 ; " \ > + "setexpr update_nand_step " \ > + "${update_nand_stride} * ${nand_writesize} ; " \ > + "while test ${i} -gt 0 ; do " \ > + "echo ${update_nand_offset} ; " \ > + "nand scrub -y ${update_nand_offset} " \ > + "${nand_erasesize} ; " \ > + "nand write.raw ${loadaddr} " \ > + "${update_nand_offset} " \ > + "${update_nand_stride} ; " \ Uh, I think this might need to be update_nand_step instead of update_nand_stride here. [...] Best regards, Marek Vasut