From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] ums: Extend ums to use all mmc devices.
Date: Wed, 28 Aug 2013 13:03:28 +0200 [thread overview]
Message-ID: <201308281303.28382.marex@denx.de> (raw)
In-Reply-To: <521DD7FE.5010403@samsung.com>
Dear Przemyslaw Marczak,
> On 08/28/2013 10:44 AM, Marek Vasut wrote:
> > You still use dev_num further in the code, why not convert the whole
> > thing to use *mmc ?
> >
> > Best regards,
> > Marek Vasut.
>
> Hello,
> I don't know exactly what do you mean.
> I suppose that putting "mmc device number" as a parameter is easy to
> maintain at command code and also intuitive to use at prompt.
> Do you prefer set mmc dev number by command "mmc dev <num>" ?
> Should we depends one command on another? If yes, then what about e.g.
> fat or ext command set?
What I mean is ... for example, you pass dev_num to board_ums_init() . See the
trats board, find_mmc_device() is called again in there. Why not just pass the
*mmc directly?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-08-28 11:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 10:53 [U-Boot] [PATCH 1/3] arm:mmc:goni/exynos: Fix wrong mmc base register devices offset Przemyslaw Marczak
2013-08-20 10:53 ` [U-Boot] [PATCH 2/3] arm:goni:mmc: Add sd card detection and initialization Przemyslaw Marczak
2013-08-28 7:39 ` Przemyslaw Marczak
2013-08-28 8:41 ` Jaehoon Chung
2013-08-28 10:11 ` Przemyslaw Marczak
2013-08-28 14:36 ` [U-Boot] [PATCH v2] " Przemyslaw Marczak
2013-08-29 3:11 ` Jaehoon Chung
2013-08-30 2:16 ` Minkyu Kang
2013-09-02 14:05 ` Przemyslaw Marczak
2013-08-20 10:53 ` [U-Boot] [PATCH 3/3] ums: Extend ums to use all mmc devices Przemyslaw Marczak
2013-08-28 7:40 ` Przemyslaw Marczak
2013-08-28 8:44 ` Marek Vasut
2013-08-28 10:59 ` Przemyslaw Marczak
2013-08-28 11:03 ` Marek Vasut [this message]
2013-08-28 11:21 ` Przemyslaw Marczak
2013-08-28 11:25 ` Marek Vasut
2013-08-28 7:11 ` [U-Boot] [PATCH 1/3] arm:mmc:goni/exynos: Fix wrong mmc base register devices offset Przemyslaw Marczak
2013-08-28 8:45 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201308281303.28382.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox