From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Wed, 28 Aug 2013 13:03:28 +0200
Subject: [U-Boot] [PATCH 3/3] ums: Extend ums to use all mmc devices.
In-Reply-To: <521DD7FE.5010403@samsung.com>
References: <1376995992-20870-1-git-send-email-p.marczak@samsung.com>
	<201308281044.34429.marex@denx.de> <521DD7FE.5010403@samsung.com>
Message-ID: <201308281303.28382.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Przemyslaw Marczak,

> On 08/28/2013 10:44 AM, Marek Vasut wrote:
> > You still use dev_num further in the code, why not convert the whole
> > thing to use *mmc ?
> > 
> > Best regards,
> > Marek Vasut.
> 
> Hello,
> I don't know exactly what do you mean.
> I suppose that putting "mmc device number" as a parameter is easy to
> maintain at command code and also intuitive to use at prompt.
> Do you prefer set mmc dev number by command "mmc dev <num>" ?
> Should we depends one command on another? If yes, then what about e.g.
> fat or ext command set?

What I mean is ... for example, you pass dev_num to board_ums_init() . See the 
trats board, find_mmc_device() is called again in there. Why not just pass the 
*mmc directly?

Best regards,
Marek Vasut