From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] config.mk: Delete unnecessary code
Date: Wed, 28 Aug 2013 15:19:25 +0900 [thread overview]
Message-ID: <20130828151925.85DF.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <1375244171-23688-1-git-send-email-yamada.m@jp.panasonic.com>
Hello, Tom.
I noticed this patch does not apply to the current u-boot/master
because commit 3aa29de0 modified the same part.
(BTW, I think CONFIG_TPL_PAD_TO is not necessary either and should be deleted.)
Should I need to post version 2 which is rebased on the current master?
(if my patch deserves that, of course.)
Or are you going to resolve the conflict?
The conflict dons not seem so comprecated.
Best Regards
Masahiro Yamada
On Wed, 31 Jul 2013 13:16:11 +0900
Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:
> Currently no makefiles set the following variables:
>
> CONFIG_SPL_TEXT_BASE
> CONFIG_UBOOT_PAD_TO
> CONFIG_RESET_VECTOR_ADDRESS
>
> For all targets which use above macros
> they are set in header files (include/configs/*.h),
> so we do not need to set them as CPPFLAGS.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
> config.mk | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/config.mk b/config.mk
> index b16fad8..240b6df 100644
> --- a/config.mk
> +++ b/config.mk
> @@ -206,18 +206,10 @@ ifneq ($(CONFIG_SYS_TEXT_BASE),)
> CPPFLAGS += -DCONFIG_SYS_TEXT_BASE=$(CONFIG_SYS_TEXT_BASE)
> endif
>
> -ifneq ($(CONFIG_SPL_TEXT_BASE),)
> -CPPFLAGS += -DCONFIG_SPL_TEXT_BASE=$(CONFIG_SPL_TEXT_BASE)
> -endif
> -
> ifneq ($(CONFIG_SPL_PAD_TO),)
> CPPFLAGS += -DCONFIG_SPL_PAD_TO=$(CONFIG_SPL_PAD_TO)
> endif
>
> -ifneq ($(CONFIG_UBOOT_PAD_TO),)
> -CPPFLAGS += -DCONFIG_UBOOT_PAD_TO=$(CONFIG_UBOOT_PAD_TO)
> -endif
> -
> ifeq ($(CONFIG_SPL_BUILD),y)
> CPPFLAGS += -DCONFIG_SPL_BUILD
> endif
> @@ -230,10 +222,6 @@ Please undefined CONFIG_SYS_GENERIC_BOARD in your board config file)
> endif
> endif
>
> -ifneq ($(RESET_VECTOR_ADDRESS),)
> -CPPFLAGS += -DRESET_VECTOR_ADDRESS=$(RESET_VECTOR_ADDRESS)
> -endif
> -
> ifneq ($(OBJTREE),$(SRCTREE))
> CPPFLAGS += -I$(OBJTREE)/include2 -I$(OBJTREE)/include
> endif
> --
> 1.8.1.2
next prev parent reply other threads:[~2013-08-28 6:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 4:16 [U-Boot] [PATCH] config.mk: Delete unnecessary code Masahiro Yamada
2013-08-28 6:19 ` Masahiro Yamada [this message]
2013-08-30 21:09 ` Tom Rini
2013-09-01 6:11 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130828151925.85DF.AA925319@jp.panasonic.com \
--to=yamada.m@jp.panasonic.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox