From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 4 Sep 2013 03:55:06 +0200 Subject: [U-Boot] [RFC PATCH 1/3] USB: gadget: add atmel usba udc driver In-Reply-To: <52268F0F.7080102@atmel.com> References: <1378180030-26101-1-git-send-email-voice.shen@atmel.com> <201309040030.57126.marex@denx.de> <52268F0F.7080102@atmel.com> Message-ID: <201309040355.06964.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Bo Shen, > Hi Marek Vasut, > > On 09/04/2013 06:30 AM, Marek Vasut wrote: > > Dear Bo Shen, > > > >> Add atmel usba udc driver support, porting from Linux kernel > >> > >> Signed-off-by: Bo Shen > > > > Please see [1] , point 4. I miss the exact point in Linux kernel history > > (read commit hash) from which this code was imported at least. > > > > [1] > > http://www.denx.de/wiki/view/U-Boot/Patches#Attributing_Code_Copyrights_ > > Sign > > Thanks. > > I will add this information into v2 after you finish reviewing the code. > > The original code information from Linux kernel as following > ---8>--- > commit e01ee9f509a927158f670408b41127d4166db1c7 > Author: Jingoo Han > Date: Tue Jul 30 17:00:51 2013 +0900 > > usb: gadget: use dev_get_platdata() > > Use the wrapper function for retrieving the platform data instead of > accessing dev->platform_data directly. > > Signed-off-by: Jingoo Han > Signed-off-by: Felipe Balbi > ---<8--- > The code looks pretty much OK. Best regards, Marek Vasut