From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: gadget: Fix data aborts during USB ethernet boot
Date: Wed, 4 Sep 2013 23:38:18 +0200 [thread overview]
Message-ID: <201309042338.18667.marex@denx.de> (raw)
In-Reply-To: <5227A691.1080602@ti.com>
Dear Joel Fernandes,
> On 08/27/2013 08:52 AM, Marek Vasut wrote:
> > Dear Joel Fernandes,
> >
> >> As seen on GCC 4.6 Linaro compiler, control_req buffer is not aligned
> >> on 4 byte boundaray causing data aborts in eth_setup -> conf_buf
> >> during dhcp boot over usb_ether. Fix the issue my aligning control_req
> >> buffer to 4-byte boundary.
> >>
> >> Tested on am335x_evm platform (beaglebone).
> >> Applies on 2013.10-rc1 branch.
> >>
> >> Cc: Tom Rini <trini@ti.com>
> >> Signed-off-by: Joel Fernandes <joelf@ti.com>
> >
> > Please keep me in the CC next time.
>
> Ok.
>
> >> ---
> >>
> >> drivers/usb/gadget/ether.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c
> >> index 579893c..251d7b2 100644
> >> --- a/drivers/usb/gadget/ether.c
> >> +++ b/drivers/usb/gadget/ether.c
> >> @@ -849,7 +849,7 @@ static struct usb_gadget_strings stringtab = {
> >>
> >> };
> >>
> >> /*=====================================================================
> >> ===
> >>
> >> ====*/ -static u8 control_req[USB_BUFSIZ];
> >> +static u8 control_req[USB_BUFSIZ] __attribute__ ((aligned(4)));
> >
> > Please make this cacheline aligned, so we get rid of bounce buffering of
> > the requests on stupid hardware.
> >
> >> #if defined(CONFIG_USB_ETH_CDC) || defined(CONFIG_USB_ETH_RNDIS)
> >> static u8 status_req[STATUS_BYTECOUNT] __attribute__ ((aligned(4)));
> >
> > This could also use fixing, but the STATUS_BYTECOUNT would need to be
> > up-aligned as well then. Some DEFINE_CACHE_ALIGN_BUFFER might help in
> > both cases here.
>
> Ok, how about __aligned(CONFIG_SYS_CACHELINE_SIZE) instead of defining
> a new DEFINE_CACHE_ALIGN_BUFFER macro?
THis is already defined and used throughout the USB code, check include/common.h
IIRC.
> Can you explain what you meant by STATUS_BYTECOUNT up-aligned and why its
> needed to be up-aligned?
it's 16 bytes now, no? Up-align it to cacheline size.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-09-04 21:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 23:32 [U-Boot] [PATCH] usb: gadget: Fix data aborts during USB ethernet boot Joel Fernandes
2013-08-27 13:52 ` Marek Vasut
2013-09-04 21:30 ` Joel Fernandes
2013-09-04 21:38 ` Marek Vasut [this message]
2013-09-04 21:54 ` Joel Fernandes
2013-09-04 22:02 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309042338.18667.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox