From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 5 Sep 2013 15:46:35 +0200 Subject: [U-Boot] [PATCH v3] usb: gadget: Fix data aborts during USB ethernet boot In-Reply-To: <5227DEF0.80208@atmel.com> References: <1378338914-11000-1-git-send-email-joelf@ti.com> <5227DEF0.80208@atmel.com> Message-ID: <201309051546.35642.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Bo Shen, > Hi Joel Fernandes, > > On 09/05/2013 07:55 AM, Joel Fernandes wrote: > > As seen on GCC 4.6 Linaro compiler, control_req buffer is not aligned > > on 4 byte boundaray causing data aborts in eth_setup -> conf_buf > > during dhcp boot over usb_ether. Fix the issue my aligning control_req > > buffer using DEFINE_CACHE_ALIGN_BUFFER. > > > > Tested on am335x_evm platform (beaglebone). > > Applies on 2013.10-rc1 branch. > > > > Cc: Tom Rini > > Cc: Marek Vasut > > Signed-off-by: Joel Fernandes > > --- > > > > v2 changes: > > - Using DEFINE_CACHE_ALIGN_BUFFER macro for the alignment. > > - Also fixed alignment for status_req. > > > > v3 changes: > > - Adjusted commit message for v2 change. > > > > drivers/usb/gadget/ether.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > Test on sama5d3xek board with RNDIS gadget, it still has the unaligned > access issue. > > However, I test with this patch "usb: gadget: config: fix unaligned > access issues" from: Troy Kisky really > fix the unaligned access issue. > > more information at: http://patchwork.ozlabs.org/patch/264151/ Troy, care to fix up the patch's commit log so I can try and understand it? Best regards, Marek Vasut