From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 12 Sep 2013 16:05:04 +0200 Subject: [U-Boot] [PATCH] net: fec: Avoid MX28 bus sync issue In-Reply-To: <52319F63.2030409@digi.com> References: <1373583784-7129-1-git-send-email-marex@denx.de> <201309121250.36579.marex@denx.de> <52319F63.2030409@digi.com> Message-ID: <201309121605.04824.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Robert Hodaszi, > Hi, > > Sorry, hopefully that will be a plain-text. > > There are a lot of bug announcement, just make a search: > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33721 This was apparently fixed three years ago. > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16660 And this one six years ago ... > Also, I printed out the buffer addresses, and that temporary RX buffer > was not aligned. So the transmit function rounded it down to the > alignment boundary, and so caused invalid data transmission. (By the > way. Shouldn't the transmit function check whether the alignment is > proper, and throw an error message, instead of round it down? That would > make more sense.) Looking at the code one more time, it'd make most sense to simply allocate the buffer NOT on stack, but with some memalign-kind-of call to avoid this abuse of stack. You see, the max packet size is around 2k, which is quite a lot. How does this proposal sound to you ? Best regards, Marek Vasut