public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH RFC] usb: Prevent using reserved registers on DM36x usb
Date: Fri, 13 Sep 2013 15:53:00 +0200	[thread overview]
Message-ID: <201309131553.00263.marex@denx.de> (raw)
In-Reply-To: <1379067189-2082-1-git-send-email-amurray@embedded-bits.co.uk>

Dear Andrew Murray,

> The musb driver defines and uses MUSB_CSR0_H_DIS_PING, however this
> bit is reserved on the DM36x. Thus this patch ensures that the
> reserved bit is not accesssed.
> 
> It has been observed that some USB devices will fail to enumerate
> with errors such as 'error in inquiry' without this patch.
> 
> See http://www.ti.com/litv/pdf/sprufh9a for details.
> 
> Cc: Marek Vasut <marex@denx.de>
> Cc: Tom Rini <trini@ti.com>
> Signed-off-by: Andrew Murray <amurray@embedded-bits.co.uk>
> ---
>  drivers/usb/musb/musb_core.h |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/musb/musb_core.h b/drivers/usb/musb/musb_core.h
> index ec8a038..c9a9d66 100644
> --- a/drivers/usb/musb/musb_core.h
> +++ b/drivers/usb/musb/musb_core.h
> @@ -216,7 +216,11 @@ struct musb_regs {
>  #define MUSB_CSR0_P_SENTSTALL	0x0004
> 
>  /* CSR0 in Host mode */
> +#if defined(CONFIG_SOC_DM365)
> +#define MUSB_CSR0_H_DIS_PING		0x0000
> +#else
>  #define MUSB_CSR0_H_DIS_PING		0x0800
> +#endif
>  #define MUSB_CSR0_H_WR_DATATOGGLE	0x0400	/* Set to allow setting: */
>  #define MUSB_CSR0_H_DATATOGGLE		0x0200	/* Data toggle control 
*/
>  #define MUSB_CSR0_H_NAKTIMEOUT		0x0080

It would be much nicer if you avoided using this bit in musb_hcd.c instead of 
hacking it like this.

Best regards,
Marek Vasut

  reply	other threads:[~2013-09-13 13:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-13 10:13 [U-Boot] [PATCH RFC] usb: Prevent using reserved registers on DM36x usb Andrew Murray
2013-09-13 13:53 ` Marek Vasut [this message]
2013-09-27 18:10   ` Marek Vasut
2013-09-29 17:06     ` Andrew Murray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201309131553.00263.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox