From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: fec: Avoid MX28 bus sync issue
Date: Fri, 13 Sep 2013 18:24:52 +0200 [thread overview]
Message-ID: <201309131824.52506.marex@denx.de> (raw)
In-Reply-To: <20130913160644.CA908380621@gemini.denx.de>
Dear Wolfgang Denk,
> Dear Robert Hodaszi,
>
> In message <5232F2E7.4050407@digi.com> you wrote:
> > Ok. Then what about if I would use the stack, but align the buffer
> > manually.
>
> Has this been tested? Does it work?
>
> > - uchar buff[FEC_MAX_PKT_SIZE] __aligned(ARCH_DMA_MINALIGN);
> > + /* Align the receive buffer */
> > + uchar buff_unaligned[FEC_MAX_PKT_SIZE + (ARCH_DMA_MINALIGN - 1)];
> > + uchar *buff = ((uint32_t)buff_unaligned + (ARCH_DMA_MINALIGN -
> > 1)) & ~(ARCH_DMA_MINALIGN - 1);
>
> You should use the ALIGN() macro here.
We already have this stuff in include/common.h ... ALLOC_CACHE_ALIGNED_BUFFER it
is called IIRC
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-09-13 16:24 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 23:03 [U-Boot] [PATCH] net: fec: Avoid MX28 bus sync issue Marek Vasut
2013-07-11 23:18 ` Fabio Estevam
2013-07-12 3:41 ` Alexandre Pereira da Silva
2013-07-12 3:51 ` Marek Vasut
2013-07-12 11:37 ` Hector Palacios
2013-07-12 11:39 ` Fabio Estevam
2013-07-12 12:01 ` Marek Vasut
2013-07-12 15:08 ` Hector Palacios
2013-07-12 15:50 ` Albert ARIBAUD
2013-07-12 16:48 ` Marek Vasut
2013-07-15 8:58 ` Hector Palacios
2013-07-15 12:30 ` Marek Vasut
2013-07-15 15:09 ` Hector Palacios
2013-07-15 15:12 ` Marek Vasut
2013-07-15 15:24 ` Hector Palacios
2013-07-16 3:51 ` Fabio Estevam
2013-07-16 4:18 ` Fabio Estevam
2013-07-16 4:44 ` Marek Vasut
2013-07-17 15:55 ` Hector Palacios
2013-07-18 4:12 ` Marek Vasut
2013-09-12 10:22 ` Hector Palacios
2013-09-12 10:50 ` Marek Vasut
[not found] ` <52319DE8.5080607@digi.com>
2013-09-12 11:00 ` Marek Vasut
2013-09-12 11:02 ` Robert Hodaszi
2013-09-12 14:05 ` Marek Vasut
2013-09-12 14:15 ` Robert Hodaszi
2013-09-12 14:31 ` Marek Vasut
2013-09-12 14:32 ` Robert Hodaszi
2013-09-12 15:06 ` Marek Vasut
2013-09-12 18:17 ` Wolfgang Denk
2013-09-12 18:39 ` Fabio Estevam
2013-09-12 18:53 ` Wolfgang Denk
2013-09-12 19:37 ` Fabio Estevam
2013-09-13 11:11 ` Robert Hodaszi
2013-09-13 11:13 ` Robert Hodaszi
2013-09-13 14:01 ` Marek Vasut
2013-09-13 14:24 ` Robert Hodaszi
2013-09-13 16:06 ` Wolfgang Denk
2013-09-13 16:24 ` Marek Vasut [this message]
2013-09-13 17:46 ` Wolfgang Denk
2013-09-14 22:05 ` Fabio Estevam
2013-09-12 11:08 ` Robert Hodaszi
2013-09-12 18:12 ` Wolfgang Denk
2013-09-12 17:50 ` Wolfgang Denk
2013-07-13 2:43 ` Troy Kisky
2013-07-15 13:41 ` Albert ARIBAUD
2013-07-15 17:39 ` Troy Kisky
2013-07-15 19:59 ` Troy Kisky
2013-07-15 20:20 ` Albert ARIBAUD
2013-07-15 20:20 ` Albert ARIBAUD
2013-07-15 21:18 ` Troy Kisky
2013-07-12 5:57 ` Albert ARIBAUD
2013-07-12 6:39 ` Albert ARIBAUD
2013-07-12 11:51 ` Marek Vasut
2013-07-12 6:56 ` Stefano Babic
2013-07-12 7:30 ` Stefano Babic
-- strict thread matches above, loose matches on Subject: below --
2013-09-15 18:12 Oliver Metz
2013-09-15 18:16 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309131824.52506.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox