From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: spl: Do not set the stack pointer twice
Date: Sat, 14 Sep 2013 11:42:08 +0200 [thread overview]
Message-ID: <20130914114208.58b95613@lilith> (raw)
In-Reply-To: <1374060955-13070-1-git-send-email-yamada.m@jp.panasonic.com>
Hi Masahiro,
On Wed, 17 Jul 2013 20:35:55 +0900, Masahiro Yamada
<yamada.m@jp.panasonic.com> wrote:
> Because the stack pointer is already set in arch/arm/lib/crt0.S,
> we do not need to set it in arch/arm/lib/spl.c.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
> arch/arm/lib/spl.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm/lib/spl.c b/arch/arm/lib/spl.c
> index 301f082..b5a1324 100644
> --- a/arch/arm/lib/spl.c
> +++ b/arch/arm/lib/spl.c
> @@ -41,9 +41,6 @@ gd_t gdata __attribute__ ((section(".data")));
> */
> void __weak board_init_f(ulong dummy)
> {
> - /* Set the stack pointer. */
> - asm volatile("mov sp, %0\n" : : "r"(CONFIG_SPL_STACK));
> -
> /* Clear the BSS. */
> memset(__bss_start, 0, __bss_end - __bss_start);
>
Applied to u-boot-arm/master, thanks!
Amicalement,
--
Albert.
prev parent reply other threads:[~2013-09-14 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 11:35 [U-Boot] [PATCH] arm: spl: Do not set the stack pointer twice Masahiro Yamada
2013-09-14 9:42 ` Albert ARIBAUD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130914114208.58b95613@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox