From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Sat, 14 Sep 2013 11:42:08 +0200 Subject: [U-Boot] [PATCH] arm: spl: Do not set the stack pointer twice In-Reply-To: <1374060955-13070-1-git-send-email-yamada.m@jp.panasonic.com> References: <1374060955-13070-1-git-send-email-yamada.m@jp.panasonic.com> Message-ID: <20130914114208.58b95613@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Masahiro, On Wed, 17 Jul 2013 20:35:55 +0900, Masahiro Yamada wrote: > Because the stack pointer is already set in arch/arm/lib/crt0.S, > we do not need to set it in arch/arm/lib/spl.c. > > Signed-off-by: Masahiro Yamada > --- > arch/arm/lib/spl.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/arm/lib/spl.c b/arch/arm/lib/spl.c > index 301f082..b5a1324 100644 > --- a/arch/arm/lib/spl.c > +++ b/arch/arm/lib/spl.c > @@ -41,9 +41,6 @@ gd_t gdata __attribute__ ((section(".data"))); > */ > void __weak board_init_f(ulong dummy) > { > - /* Set the stack pointer. */ > - asm volatile("mov sp, %0\n" : : "r"(CONFIG_SPL_STACK)); > - > /* Clear the BSS. */ > memset(__bss_start, 0, __bss_end - __bss_start); > Applied to u-boot-arm/master, thanks! Amicalement, -- Albert.