* [U-Boot] [PATCH] arm: spl: Do not set the stack pointer twice
@ 2013-07-17 11:35 Masahiro Yamada
2013-09-14 9:42 ` Albert ARIBAUD
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2013-07-17 11:35 UTC (permalink / raw)
To: u-boot
Because the stack pointer is already set in arch/arm/lib/crt0.S,
we do not need to set it in arch/arm/lib/spl.c.
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---
arch/arm/lib/spl.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm/lib/spl.c b/arch/arm/lib/spl.c
index 301f082..b5a1324 100644
--- a/arch/arm/lib/spl.c
+++ b/arch/arm/lib/spl.c
@@ -41,9 +41,6 @@ gd_t gdata __attribute__ ((section(".data")));
*/
void __weak board_init_f(ulong dummy)
{
- /* Set the stack pointer. */
- asm volatile("mov sp, %0\n" : : "r"(CONFIG_SPL_STACK));
-
/* Clear the BSS. */
memset(__bss_start, 0, __bss_end - __bss_start);
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* [U-Boot] [PATCH] arm: spl: Do not set the stack pointer twice
2013-07-17 11:35 [U-Boot] [PATCH] arm: spl: Do not set the stack pointer twice Masahiro Yamada
@ 2013-09-14 9:42 ` Albert ARIBAUD
0 siblings, 0 replies; 2+ messages in thread
From: Albert ARIBAUD @ 2013-09-14 9:42 UTC (permalink / raw)
To: u-boot
Hi Masahiro,
On Wed, 17 Jul 2013 20:35:55 +0900, Masahiro Yamada
<yamada.m@jp.panasonic.com> wrote:
> Because the stack pointer is already set in arch/arm/lib/crt0.S,
> we do not need to set it in arch/arm/lib/spl.c.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
> arch/arm/lib/spl.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm/lib/spl.c b/arch/arm/lib/spl.c
> index 301f082..b5a1324 100644
> --- a/arch/arm/lib/spl.c
> +++ b/arch/arm/lib/spl.c
> @@ -41,9 +41,6 @@ gd_t gdata __attribute__ ((section(".data")));
> */
> void __weak board_init_f(ulong dummy)
> {
> - /* Set the stack pointer. */
> - asm volatile("mov sp, %0\n" : : "r"(CONFIG_SPL_STACK));
> -
> /* Clear the BSS. */
> memset(__bss_start, 0, __bss_end - __bss_start);
>
Applied to u-boot-arm/master, thanks!
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-14 9:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-17 11:35 [U-Boot] [PATCH] arm: spl: Do not set the stack pointer twice Masahiro Yamada
2013-09-14 9:42 ` Albert ARIBAUD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox