[U-Boot] [PATCH v2] Merge and reformat boards.cfg and MAINTAINERS

Albert ARIBAUD
2013-09-15T05:36:05Z

Hi Roger,

On Thu, 12 Sep 2013 13:18:20 +0000, "Meier, Roger"
<r.meier@siemens.com> wrote:

> Hi Albert
> > -----Original Message-----
> > From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On
> > Behalf Of Albert ARIBAUD
> > Sent: Mittwoch, 11. September 2013 15:53
> > To: u-boot at lists.denx.de
> > Subject: [U-Boot] [PATCH v2] Merge and reformat boards.cfg and MAINTAINERS
> >
> > Put all informations about targets, including state (active or
> > orphan) and maintainers, in boards.cfg; remove MAINTAINERS;
> > adjust the build system accordingly.
> >
> > Signed-off-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
> > ---
> > V2:
> > - updated with latest boards.cfg/MAINTAINER info
> > - fixed wrong maintainer(s) for orphan boards
> > - fixed wrong maintainer(s) for base:options case
> > - fixed lingering misuses of boards.cfg and MAINTAINERS
> > V1:
> > - initial submission from squashed RFC patch series
> >
> > MAINTAINERS | 1412 ----------------------------
> > MAKEALL | 51 +-
> > Makefile | 2 +-
> > README | 6 +-
> > boards.cfg | 2345 ++++++++++++++++++++++++----------------------
> > -
> > mkconfig | 31 +-
> > tools/buildman/board.py | 2 +-
> > tools/reformat.py | 132 +++
> > 8 files changed, 1350 insertions(+), 2631 deletions(-)
> > delete mode 100644 MAINTAINERS
> > create mode 100755 tools/reformat.py
> >
>
> I really like that simplification!
>
> tools/checkpatch.pl detected these errors:
> ---SNIP---
> ERROR: trailing whitespace
> #4055: FILE: tools/reformat.py:32:
> +# ^I$
>
> ERROR: trailing whitespace
> #4125: FILE: tools/reformat.py:102:
> +^I^I# any missing field is set to default if it exists $
> ---SNIP---
>
> and I recognized that tools/checkpatch.pl needs the patch below.
>
> Regards,
> Roger
>
> diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
> index 896e2bc..88c5bc7 100755
> --- a/tools/checkpatch.pl
> +++ b/tools/checkpatch.pl
> @@ -398,7 +398,7 @@ sub top_of_kernel_tree {
> my ($root) = @_;
>
> my @tree_check = (
> - "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
> + "COPYING", "CREDITS", "Kbuild", "Makefile",
> "README", "Documentation", "arch", "include", "drivers",
> "fs", "init", "ipc", "kernel", "lib", "scripts",
> );
> @@ -3701,7 +3701,7 @@ sub process {
> $vname has style problems, please review.
>
> If any of these errors are false positives, please report
> -them to the maintainer, see CHECKPATCH in MAINTAINERS.
> +them to the maintainer, see boards.cfg.
> EOM
> }

Thanks! I thought I'd done a grep -i MAINTAINERS before posting,
obviously I hadn't.

Could you send thoses two fixes as as a proper, standalone git patch
rather than a reply to another patch, so that they can be properly
attributed to you?

Amicalement,
--
Albert.