* [U-Boot] worth correcting spelling of "redundand"?
@ 2013-09-16 8:30 Robert P. J. Day
2013-09-16 11:03 ` Albert ARIBAUD
0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2013-09-16 8:30 UTC (permalink / raw)
To: u-boot
again, my pedantry getting the best of me but it makes me cringe
whenever i run across the spelling "redundand" (tree-wide search):
common/env_ubi.c:#ifdef CONFIG_SYS_REDUNDAND_ENVIRONMENT
common/env_ubi.c:#else /* ! CONFIG_SYS_REDUNDAND_ENVIRONMENT */
common/env_ubi.c:#endif /* CONFIG_SYS_REDUNDAND_ENVIRONMENT */
common/env_ubi.c:#ifdef CONFIG_SYS_REDUNDAND_ENVIRONMENT
common/env_ubi.c:#else /* ! CONFIG_SYS_REDUNDAND_ENVIRONMENT */
common/env_ubi.c:#endif /* CONFIG_SYS_REDUNDAND_ENVIRONMENT */
common/env_embedded.c:env_t redundand_environment __PPCENV__ = {
include/environment.h:# define CONFIG_SYS_REDUNDAND_ENVIRONMENT
include/environment.h:# define CONFIG_SYS_REDUNDAND_ENVIRONMENT
include/environment.h:# define CONFIG_SYS_REDUNDAND_ENVIRONMENT
include/environment.h:# define CONFIG_SYS_REDUNDAND_ENVIRONMENT
include/environment.h:#ifdef CONFIG_SYS_REDUNDAND_ENVIRONMENT
include/environment.h:#ifdef CONFIG_SYS_REDUNDAND_ENVIRONMENT
include/env_default.h:#ifdef CONFIG_SYS_REDUNDAND_ENVIRONMENT
include/configs/G2000.h:#else /* DEFAULT: environment in flash, using redundand flash sectors */
include/configs/km/km_arm.h:#define CONFIG_SYS_REDUNDAND_ENVIRONMENT
include/configs/PPChameleonEVB.h:#else /* DEFAULT: environment in flash, using redundand flash sectors */
include/configs/mx28evk.h:#define CONFIG_SYS_REDUNDAND_ENVIRONMENT
include/configs/am335x_evm.h:#define CONFIG_SYS_REDUNDAND_ENVIRONMENT
include/configs/omap5_uevm.h:#define CONFIG_SYS_REDUNDAND_ENVIRONMENT
include/configs/igep0033.h:#define CONFIG_SYS_REDUNDAND_ENVIRONMENT
tools/envcrc.c:# define CONFIG_SYS_REDUNDAND_ENVIRONMENT
tools/envcrc.c:#ifdef CONFIG_SYS_REDUNDAND_ENVIRONMENT
this obviously isn't a cosmetic change as it's used in numerous
#defines, but if it's done all at once, it should be safe. i can
submit a patch unless people feel it's simply too disruptive.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 2+ messages in thread
* [U-Boot] worth correcting spelling of "redundand"?
2013-09-16 8:30 [U-Boot] worth correcting spelling of "redundand"? Robert P. J. Day
@ 2013-09-16 11:03 ` Albert ARIBAUD
0 siblings, 0 replies; 2+ messages in thread
From: Albert ARIBAUD @ 2013-09-16 11:03 UTC (permalink / raw)
To: u-boot
Hi Robert,
On Mon, 16 Sep 2013 04:30:09 -0400 (EDT), "Robert P. J. Day"
<rpjday@crashcourse.ca> wrote:
>
> again, my pedantry getting the best of me but it makes me cringe
> whenever i run across the spelling "redundand" (tree-wide search):
>
> common/env_ubi.c:#ifdef CONFIG_SYS_REDUNDAND_ENVIRONMENT
> [...]
>
> this obviously isn't a cosmetic change as it's used in numerous
> #defines, but if it's done all at once, it should be safe. i can
> submit a patch unless people feel it's simply too disruptive.
As a general rule, you don't need to ask before submitting a patch
unless you're really doing intrusive and potentially disruptive work
and want some feedback without risking getting bad code mainlined, in
which case... you'd still submit a patch, only tagged RFC. :)
IOW: just submit the patch; after all, the worst possible outcome is
only a NAK if you missed something important.
Here, just submit a patch with a summary line / subject like "fix
CONFIG_SYS_REDUNDAND_ENVIRONMENT typo".
> rday
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-16 11:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-16 8:30 [U-Boot] worth correcting spelling of "redundand"? Robert P. J. Day
2013-09-16 11:03 ` Albert ARIBAUD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox