From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Tue, 17 Sep 2013 17:23:35 +0200
Subject: [U-Boot] [PATCH v3 01/10] usb: Move 'bmRequestType' USB device
	request macros from EHCI header
In-Reply-To: <CAFp+6iHz7tC+p4JxNG=fJBru=A7Wkp34nVpky1ZrcNqx+vvrvQ@mail.gmail.com>
References: <1379147573-21897-1-git-send-email-gautam.vivek@samsung.com>
	<201309170502.51532.marex@denx.de>
	<CAFp+6iHz7tC+p4JxNG=fJBru=A7Wkp34nVpky1ZrcNqx+vvrvQ@mail.gmail.com>
Message-ID: <201309171723.35717.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Vivek Gautam,

> Hi Marek,
> 
> On Tue, Sep 17, 2013 at 8:32 AM, Marek Vasut <marex@denx.de> wrote:
> > Dear Vivek Gautam,
> > 
> >> Macros defining bmRequestType field of USB device request,
> >> given in table 9.2 USB 2.0 spec, are rather generic macros
> >> which can be further used by other Host controller stacks.
> >> So moving them to usb_defs header.
> >> 
> >> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> >> Cc: Julius Werner <jwerner@chromium.org>
> >> Cc: Simon Glass <sjg@chromium.org>
> >> Cc: Minkyu Kang <mk7.kang@samsung.com>
> >> Cc: Dan Murphy <dmurphy@ti.com>
> >> Cc: Marek Vasut <marex@denx.de>
> > 
> > Why not just use include/usb.h ?
> 
> The bit field definitions for usb-types usb-recipient, and directions
> are itself defined in usb_defs.h;
> so i thought of keeping their combination just below it, so that it
> would not be difficult to reference.
> 
> Please let me know if you want me to move them to include/usb.h

Ah, we already have usb_defs.h , then this is OK. The headers are mess and will 
eventually need cleanup too, not in this patchset of course.

Best regards,
Marek Vasut