From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 18 Sep 2013 17:32:06 +0200 Subject: [U-Boot] [PATCH v2] net: fec_mxc: Fix timeouts during tftp transfer In-Reply-To: <1379470390-19279-1-git-send-email-festevam@gmail.com> References: <1379470390-19279-1-git-send-email-festevam@gmail.com> Message-ID: <201309181732.06996.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Fabio Estevam, > From: Fabio Estevam > > Performing tftp transfers on mx28 results in random timeouts. > > Hector Palacios and Robert Hodaszi analyzed the root cause being related to > the wrong alignment of the 'buff' buffer inside fec_recv(). > > Beno?t Th?baudeau provided an excellent analysis of the alignment bug that > is present on older versions, such as GCC 4.5.4: > > http://marc.info/?l=u-boot&m=137942904906131&w=2 > > Use ALLOC_CACHE_ALIGN_BUFFER() to avoid alignment issues from older GCC > versions. > > Reported-by: Hector Palacios > Tested-by: Oliver Metz > Tested-by: Hector Palacios > Signed-off-by: Fabio Estevam > --- > Changes since v1: > - Improve commit log > - Add Hector's Tested-by tag > > drivers/net/fec_mxc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Marek Vasut Tested-by: Marek Vasut Stefano, can you please apply for .10 ? Best regards, Marek Vasut