public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] arm: rmobile: kzm9g: Change clock definition of SCIF from CONFIG_SYS_CLK_FREQ to CONFIG_SH_SCIF_CLK_FREQ
Date: Thu, 19 Sep 2013 11:09:59 +0200	[thread overview]
Message-ID: <20130919110959.79602ca1@lilith> (raw)
In-Reply-To: <1377144350-28324-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>

Hi Nobuhiro,

On Thu, 22 Aug 2013 13:05:49 +0900, Nobuhiro Iwamatsu
<nobuhiro.iwamatsu.yj@renesas.com> wrote:

> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> ---
>  include/configs/kzm9g.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/configs/kzm9g.h b/include/configs/kzm9g.h
> index 222725c..6323050 100644
> --- a/include/configs/kzm9g.h
> +++ b/include/configs/kzm9g.h
> @@ -125,6 +125,7 @@
>  #define CONFIG_GLOBAL_TIMER
>  #define CONFIG_SYS_CLK_FREQ	(48000000)
>  #define CONFIG_SYS_CPU_CLK	(1196000000)
> +#define CONFIG_SH_SCIF_CLK_FREQ CONFIG_SYS_CLK_FREQ
>  #define TMU_CLK_DIVIDER		(4)	/* 4 (default), 16, 64, 256 or 1024 */
>  #define CFG_HZ              (1000)
>  #define CONFIG_SYS_HZ		CFG_HZ

What's the point of this series? It only adds a define, but the
current codebase does not use it anywhere, so obviously it's "dead
code". If there is a further series which needs this define, then
include these patches in that further series.

Amicalement,
-- 
Albert.

  parent reply	other threads:[~2013-09-19  9:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-22  4:05 [U-Boot] [PATCH 1/2] arm: rmobile: kzm9g: Change clock definition of SCIF from CONFIG_SYS_CLK_FREQ to CONFIG_SH_SCIF_CLK_FREQ Nobuhiro Iwamatsu
2013-08-22  4:05 ` [U-Boot] [PATCH 2/2] arm: rmobile: armadillo-800eva: Change clock definition of SCIF and TMU Nobuhiro Iwamatsu
2013-09-19  9:09 ` Albert ARIBAUD [this message]
2013-09-20  0:21   ` [U-Boot] [PATCH 1/2] arm: rmobile: kzm9g: Change clock definition of SCIF from CONFIG_SYS_CLK_FREQ to CONFIG_SH_SCIF_CLK_FREQ Nobuhiro Iwamatsu
2013-09-21  8:47     ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130919110959.79602ca1@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox