* [U-Boot] [PATCH 1/2] arm: rmobile: kzm9g: Change clock definition of SCIF from CONFIG_SYS_CLK_FREQ to CONFIG_SH_SCIF_CLK_FREQ
@ 2013-08-22 4:05 Nobuhiro Iwamatsu
2013-08-22 4:05 ` [U-Boot] [PATCH 2/2] arm: rmobile: armadillo-800eva: Change clock definition of SCIF and TMU Nobuhiro Iwamatsu
2013-09-19 9:09 ` [U-Boot] [PATCH 1/2] arm: rmobile: kzm9g: Change clock definition of SCIF from CONFIG_SYS_CLK_FREQ to CONFIG_SH_SCIF_CLK_FREQ Albert ARIBAUD
0 siblings, 2 replies; 5+ messages in thread
From: Nobuhiro Iwamatsu @ 2013-08-22 4:05 UTC (permalink / raw)
To: u-boot
Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
---
include/configs/kzm9g.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/configs/kzm9g.h b/include/configs/kzm9g.h
index 222725c..6323050 100644
--- a/include/configs/kzm9g.h
+++ b/include/configs/kzm9g.h
@@ -125,6 +125,7 @@
#define CONFIG_GLOBAL_TIMER
#define CONFIG_SYS_CLK_FREQ (48000000)
#define CONFIG_SYS_CPU_CLK (1196000000)
+#define CONFIG_SH_SCIF_CLK_FREQ CONFIG_SYS_CLK_FREQ
#define TMU_CLK_DIVIDER (4) /* 4 (default), 16, 64, 256 or 1024 */
#define CFG_HZ (1000)
#define CONFIG_SYS_HZ CFG_HZ
--
1.8.3.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 2/2] arm: rmobile: armadillo-800eva: Change clock definition of SCIF and TMU
2013-08-22 4:05 [U-Boot] [PATCH 1/2] arm: rmobile: kzm9g: Change clock definition of SCIF from CONFIG_SYS_CLK_FREQ to CONFIG_SH_SCIF_CLK_FREQ Nobuhiro Iwamatsu
@ 2013-08-22 4:05 ` Nobuhiro Iwamatsu
2013-09-19 9:09 ` [U-Boot] [PATCH 1/2] arm: rmobile: kzm9g: Change clock definition of SCIF from CONFIG_SYS_CLK_FREQ to CONFIG_SH_SCIF_CLK_FREQ Albert ARIBAUD
1 sibling, 0 replies; 5+ messages in thread
From: Nobuhiro Iwamatsu @ 2013-08-22 4:05 UTC (permalink / raw)
To: u-boot
This changes clock definition of SCIF from CONFIG_SYS_CLK_FREQ to
CONFIG_SH_SCIF_CLK_FREQ, and clock definition of TMU from CONFIG_SYS_CLK_FREQ to
CONFIG_SH_TMU_CLK_FREQ,
Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
---
include/configs/armadillo-800eva.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/configs/armadillo-800eva.h b/include/configs/armadillo-800eva.h
index 9f357ea..7a264b0 100644
--- a/include/configs/armadillo-800eva.h
+++ b/include/configs/armadillo-800eva.h
@@ -138,6 +138,8 @@
/* Board Clock */
#define CONFIG_SYS_CLK_FREQ 50000000
+#define CONFIG_SH_TMU_CLK_FREQ CONFIG_SYS_CLK_FREQ
+#define CONFIG_SH_SCIF_CLK_FREQ CONFIG_SYS_CLK_FREQ
#define CONFIG_SYS_TMU_CLK_DIV 4
#define CONFIG_SYS_HZ 1000
--
1.8.3.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 1/2] arm: rmobile: kzm9g: Change clock definition of SCIF from CONFIG_SYS_CLK_FREQ to CONFIG_SH_SCIF_CLK_FREQ
2013-08-22 4:05 [U-Boot] [PATCH 1/2] arm: rmobile: kzm9g: Change clock definition of SCIF from CONFIG_SYS_CLK_FREQ to CONFIG_SH_SCIF_CLK_FREQ Nobuhiro Iwamatsu
2013-08-22 4:05 ` [U-Boot] [PATCH 2/2] arm: rmobile: armadillo-800eva: Change clock definition of SCIF and TMU Nobuhiro Iwamatsu
@ 2013-09-19 9:09 ` Albert ARIBAUD
2013-09-20 0:21 ` Nobuhiro Iwamatsu
1 sibling, 1 reply; 5+ messages in thread
From: Albert ARIBAUD @ 2013-09-19 9:09 UTC (permalink / raw)
To: u-boot
Hi Nobuhiro,
On Thu, 22 Aug 2013 13:05:49 +0900, Nobuhiro Iwamatsu
<nobuhiro.iwamatsu.yj@renesas.com> wrote:
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> ---
> include/configs/kzm9g.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/configs/kzm9g.h b/include/configs/kzm9g.h
> index 222725c..6323050 100644
> --- a/include/configs/kzm9g.h
> +++ b/include/configs/kzm9g.h
> @@ -125,6 +125,7 @@
> #define CONFIG_GLOBAL_TIMER
> #define CONFIG_SYS_CLK_FREQ (48000000)
> #define CONFIG_SYS_CPU_CLK (1196000000)
> +#define CONFIG_SH_SCIF_CLK_FREQ CONFIG_SYS_CLK_FREQ
> #define TMU_CLK_DIVIDER (4) /* 4 (default), 16, 64, 256 or 1024 */
> #define CFG_HZ (1000)
> #define CONFIG_SYS_HZ CFG_HZ
What's the point of this series? It only adds a define, but the
current codebase does not use it anywhere, so obviously it's "dead
code". If there is a further series which needs this define, then
include these patches in that further series.
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 1/2] arm: rmobile: kzm9g: Change clock definition of SCIF from CONFIG_SYS_CLK_FREQ to CONFIG_SH_SCIF_CLK_FREQ
2013-09-19 9:09 ` [U-Boot] [PATCH 1/2] arm: rmobile: kzm9g: Change clock definition of SCIF from CONFIG_SYS_CLK_FREQ to CONFIG_SH_SCIF_CLK_FREQ Albert ARIBAUD
@ 2013-09-20 0:21 ` Nobuhiro Iwamatsu
2013-09-21 8:47 ` Albert ARIBAUD
0 siblings, 1 reply; 5+ messages in thread
From: Nobuhiro Iwamatsu @ 2013-09-20 0:21 UTC (permalink / raw)
To: u-boot
Hi, Albert.
(2013/09/19 18:09), Albert ARIBAUD wrote:
> Hi Nobuhiro,
>
> On Thu, 22 Aug 2013 13:05:49 +0900, Nobuhiro Iwamatsu
> <nobuhiro.iwamatsu.yj@renesas.com> wrote:
>
>> Signed-off-by: Nobuhiro Iwamatsu<nobuhiro.iwamatsu.yj@renesas.com>
>> ---
>> include/configs/kzm9g.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/configs/kzm9g.h b/include/configs/kzm9g.h
>> index 222725c..6323050 100644
>> --- a/include/configs/kzm9g.h
>> +++ b/include/configs/kzm9g.h
>> @@ -125,6 +125,7 @@
>> #define CONFIG_GLOBAL_TIMER
>> #define CONFIG_SYS_CLK_FREQ (48000000)
>> #define CONFIG_SYS_CPU_CLK (1196000000)
>> +#define CONFIG_SH_SCIF_CLK_FREQ CONFIG_SYS_CLK_FREQ
>> #define TMU_CLK_DIVIDER (4) /* 4 (default), 16, 64, 256 or 1024 */
>> #define CFG_HZ (1000)
>> #define CONFIG_SYS_HZ CFG_HZ
>
> What's the point of this series? It only adds a define, but the
> current codebase does not use it anywhere, so obviously it's "dead
> code".
This is used by drivers/serial/serial_sh.c.
http://lists.denx.de/pipermail/u-boot/2013-August/161276.html
I already applied this to my u-boot-sh repository. But I dont pull-request yet.
I want to include in the next version of this change.
>
> If there is a further series which needs this define, then
> include these patches in that further series.
I see. I will be from next time, Is it OK?
>
> Amicalement,
Best regards,
Nobuhiro
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 1/2] arm: rmobile: kzm9g: Change clock definition of SCIF from CONFIG_SYS_CLK_FREQ to CONFIG_SH_SCIF_CLK_FREQ
2013-09-20 0:21 ` Nobuhiro Iwamatsu
@ 2013-09-21 8:47 ` Albert ARIBAUD
0 siblings, 0 replies; 5+ messages in thread
From: Albert ARIBAUD @ 2013-09-21 8:47 UTC (permalink / raw)
To: u-boot
Hi Nobuhiro,
On Fri, 20 Sep 2013 09:21:16 +0900, Nobuhiro Iwamatsu
<nobuhiro.iwamatsu.yj@renesas.com> wrote:
> Hi, Albert.
>
> (2013/09/19 18:09), Albert ARIBAUD wrote:
> > Hi Nobuhiro,
> >
> > On Thu, 22 Aug 2013 13:05:49 +0900, Nobuhiro Iwamatsu
> > <nobuhiro.iwamatsu.yj@renesas.com> wrote:
> >
> >> Signed-off-by: Nobuhiro Iwamatsu<nobuhiro.iwamatsu.yj@renesas.com>
> >> ---
> >> include/configs/kzm9g.h | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/include/configs/kzm9g.h b/include/configs/kzm9g.h
> >> index 222725c..6323050 100644
> >> --- a/include/configs/kzm9g.h
> >> +++ b/include/configs/kzm9g.h
> >> @@ -125,6 +125,7 @@
> >> #define CONFIG_GLOBAL_TIMER
> >> #define CONFIG_SYS_CLK_FREQ (48000000)
> >> #define CONFIG_SYS_CPU_CLK (1196000000)
> >> +#define CONFIG_SH_SCIF_CLK_FREQ CONFIG_SYS_CLK_FREQ
> >> #define TMU_CLK_DIVIDER (4) /* 4 (default), 16, 64, 256 or 1024 */
> >> #define CFG_HZ (1000)
> >> #define CONFIG_SYS_HZ CFG_HZ
> >
> > What's the point of this series? It only adds a define, but the
> > current codebase does not use it anywhere, so obviously it's "dead
> > code".
>
> This is used by drivers/serial/serial_sh.c.
> http://lists.denx.de/pipermail/u-boot/2013-August/161276.html
>
> I already applied this to my u-boot-sh repository. But I dont pull-request yet.
> I want to include in the next version of this change.
> >
> > If there is a further series which needs this define, then
> > include these patches in that further series.
>
> I see. I will be from next time, Is it OK?
OK -- I'll mark these 2 patches as "changes requested".
> Best regards,
> Nobuhiro
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-21 8:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-22 4:05 [U-Boot] [PATCH 1/2] arm: rmobile: kzm9g: Change clock definition of SCIF from CONFIG_SYS_CLK_FREQ to CONFIG_SH_SCIF_CLK_FREQ Nobuhiro Iwamatsu
2013-08-22 4:05 ` [U-Boot] [PATCH 2/2] arm: rmobile: armadillo-800eva: Change clock definition of SCIF and TMU Nobuhiro Iwamatsu
2013-09-19 9:09 ` [U-Boot] [PATCH 1/2] arm: rmobile: kzm9g: Change clock definition of SCIF from CONFIG_SYS_CLK_FREQ to CONFIG_SH_SCIF_CLK_FREQ Albert ARIBAUD
2013-09-20 0:21 ` Nobuhiro Iwamatsu
2013-09-21 8:47 ` Albert ARIBAUD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox