[U-Boot] [PATCH v4] usb: new board-specific USB init interface

Mateusz Zalega
2013-09-25T11:01:02Z

On 09/19/13 16:34, Marek Vasut wrote:
> I checked powerpc and "arches" "glacier" and "glacier_nand" don't build. Can you
> please check and fix ? You can get the ELDK 5.4 PPC toolchain from [1].
>
> http://www.denx.de/wiki/ELDK-5/

Hello,
it's because I moved some function declarations and had to include usb.h
in their code.

@usb.h, this giant ifdef fails:
134 #if defined(CONFIG_USB_UHCI) || defined(CONFIG_USB_OHCI) || \
135 defined(CONFIG_USB_EHCI) || defined(CONFIG_USB_OHCI_NEW) || \
136 defined(CONFIG_USB_SL811HS) ||
defined(CONFIG_USB_ISP116X_HCD) || \
137 defined(CONFIG_USB_R8A66597_HCD) ||
defined(CONFIG_USB_DAVINCI) || \
138 defined(CONFIG_USB_OMAP3) || defined(CONFIG_USB_DA8XX) || \
139 defined(CONFIG_USB_BLACKFIN) || defined(CONFIG_USB_AM35X) || \
140 defined(CONFIG_USB_MUSB_DSPS) ||
defined(CONFIG_USB_MUSB_AM35X) || \
141 defined(CONFIG_USB_MUSB_OMAP2PLUS)

and results in:
169 #error USB Lowlevel not defined

I don't like the notion of using board-specific CONFIG_* defines in
usb.h. Any ideas on where can we move it? Maybe one generic
CONFIG_USB_HOST specified in board code would do?

--
Mateusz Zalega
Samsung R&D Institute Poland