[U-Boot] [PATCH v4] usb: new board-specific USB init interface

Mateusz Zalega
2013-09-16T09:10:07Z

On 09/15/13 18:44, Marek Vasut wrote:
> Dear Mateusz Zalega,
>
>> This commit unifies board-specific USB initialization implementations
>> under one symbol (usb_board_init), declaration of which is available in
>> usb.h.
>>
>> New API allows selective initialization of USB controllers whenever needed.
>>
>> Signed-off-by: Mateusz Zalega <m.zalega@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
>> Cc: Marek Vasut <marex@denx.de>
>> Cc: Lukasz Majewski <l.majewski@samsung.com>
>> Change-Id: Ia78a1378f30a55dd14598c9a1a1b4b8a762e2cd8
>> ---
>> Changes since RFC (v1):
>> - NVIDIA Tegra doesn't postpone its USB init anymore
>> - board_usb_init()'s sole argument name was shortened
>> - networking code comment style (/* blurb...) dropped
>> - squashed RFC changes so that patch won't break bisect
>>
>> v2 changes:
>> - commit message fixup
>>
>> v3 changes:
>> - added 'index' argument to perform selective port initialization
>>
>> v4 changes:
>> - board_usb_init_fail() renamed to board_usb_cleanup()
>> - board_usb_cleanup() accepts controller index and init type
>> - DFU and UMS commands don't init all USB controllers anymore
>> - minor related fixes & refactorization
>> ---
>
> Looks pretty much OK. Did you test it on a few platforms? I'd like to apply this
> for -next anyway, since the MW is long closed.
>
> Best regards,
> Marek Vasut

I've ran MAKEALL on all arm boards and tested it on Samsung Goni.
Everything seems to be OK.

--
Mateusz Zalega
Samsung R&D Institute Poland