public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: prevent using movt/movw address loads
Date: Thu, 19 Sep 2013 17:16:29 -0400	[thread overview]
Message-ID: <20130919211629.GC5273@bill-the-cat> (raw)
In-Reply-To: <1377345338-9695-1-git-send-email-jeroen@myspectrum.nl>

On Sat, Aug 24, 2013 at 01:55:38PM +0200, Jeroen Hofstee wrote:

> The movt/movw instruction can be used to hardcode an
> memory location in the instruction itself. The linker
> starts complaining about this if the compiler decides
> to do so: "relocation R_ARM_MOVW_ABS_NC against `a local
> symbol' can not be used" and it is not support by U-boot
> as well. Prevent their use by requiring word relocations.
> This allows u-boot to be build at other optimalization
> levels then -Os.
> 
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> Cc: TigerLiu at viatech.com.cn
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> ---
>  arch/arm/config.mk | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Is this also something we need for llvm?  I am hesitant here because as
Wolfgang points out, -O0 is usually the wrong way to debug a problem and
I'll add we're well into the age where debuggers work just fine with
optimized code.  If there's some -O2 enabled gcc flag we want because of
a measurable performance win, we should add it specifically to -Os.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130919/d8945885/attachment.pgp>

  parent reply	other threads:[~2013-09-19 21:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-24 11:55 [U-Boot] [PATCH] arm: prevent using movt/movw address loads Jeroen Hofstee
2013-09-17 10:44 ` TigerLiu at viatech.com.cn
2013-09-17 18:34   ` Jeroen Hofstee
2013-09-19 21:16 ` Tom Rini [this message]
2013-09-20 17:15   ` Jeroen Hofstee
2013-09-20 18:03     ` Tom Rini
2013-09-21  2:43 ` Simon Glass
2013-09-23 13:48 ` Albert ARIBAUD
  -- strict thread matches above, loose matches on Subject: below --
2013-09-17  8:01 TigerLiu at viatech.com.cn
2013-09-17  8:35 ` Wolfgang Denk
2013-09-17  9:26   ` TigerLiu at viatech.com.cn
2013-09-17 10:19     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130919211629.GC5273@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox