From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: ehci: Fix test mode for connected ports
Date: Thu, 19 Sep 2013 23:48:38 +0200 [thread overview]
Message-ID: <201309192348.38573.marex@denx.de> (raw)
In-Reply-To: <CAODwPW-Z8ATks+c1N1YxAtDQzgYfm8=Du4vhUPoQxi2Swyv8yg@mail.gmail.com>
Dear Julius Werner,
> > Why 8 * 1000? It's not clear.
>
> I am not quite sure to be honest... it's been a while since I actually
> wrote this patch. The EHCI spec gives no clear max for the
> Periodic/Async Schedule disable (I assume not more than a frame,
> though), and says the Run/Stop bit must halt within 16 microframes
> (which would be 4.125ms). I guess 8 looked like a safe and not too
> large value that still makes the line fit on 80 characters (and it's
> not like most of the other timeouts in that file have a clear origin,
> so it's in good company). What do you want me to change it to?
I would like to hear a convincing argument why 8 is the good value. The amount
of "I guess" in the text above does not convince me.
It would be also good if you didn't sprinkle duplicates of this magic value all
around , but instead #define it somewhere and put a beefy comment above it.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-09-19 21:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 0:29 [U-Boot] [PATCH] usb: ehci: Fix test mode for connected ports Julius Werner
2013-09-18 2:13 ` Simon Glass
2013-09-18 14:44 ` Marek Vasut
2013-09-18 17:16 ` Julius Werner
2013-09-19 21:48 ` Marek Vasut [this message]
2013-09-20 1:39 ` Julius Werner
2013-09-20 5:12 ` Simon Glass
2013-09-24 2:55 ` Julius Werner
2013-09-24 4:06 ` Simon Glass
2013-09-24 6:59 ` Marek Vasut
2013-09-24 17:53 ` [U-Boot] [PATCH v2] " Julius Werner
2013-09-26 23:30 ` Simon Glass
2013-09-27 14:36 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309192348.38573.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox